chore: add avm team as codeowners to more repo files #7196
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,31 @@ | ||
| /build-images/ @charlielye | ||
|
|
||
| # Notify the Noir team of any changes to ACIR serialization | ||
| /noir/noir-repo/acvm-repo/acir/codegen/* @TomAFrench @vezenovm @guipublic | ||
|
|
||
| ##################################################### | ||
| # Notify the AVM team | ||
| # | ||
| # on changes to PIL code-generator | ||
| /bb-pilcom @Maddiaa0 @jeanmon @IlyasRidhuan @fcarreiro | ||
| # on changes to PIL code (AVM circuit) | ||
| /barretenberg/cpp/pil @Maddiaa0 @jeanmon @IlyasRidhuan @fcarreiro | ||
| # on changes to PIL-generated C++ | ||
| /barretenberg/cpp/src/barretenberg/**/generated @jeanmon @IlyasRidhuan @fcarreiro | ||
| # on changes to AVM trace (C++ witness generator) | ||
| /barretenberg/cpp/src/barretenberg/vm/avm_trace @jeanmon @IlyasRidhuan @fcarreiro | ||
|
Contributor
There was a problem hiding this comment. maybe just barretenberg/vm and everything under it |
||
| # on changes to public context in aztec-nr | ||
| /noir-projects/aztec-nr/aztec/src/context/inputs/public_context_inputs.nr @fcarreiro @dbanks12 | ||
| /noir-projects/aztec-nr/aztec/src/context/public_context.nr @fcarreiro @dbanks12 | ||
|
Comment on lines
-11
to
-14
Contributor
Author
There was a problem hiding this comment. These files don't exist anymore |
||
| # on changes to the AVM simulator and supporting modules | ||
| /yarn-project/simulator/src/avm @fcarreiro @dbanks12 | ||
| /yarn-project/simulator/src/public/execution.ts @fcarreiro @dbanks12 | ||
| /yarn-project/simulator/src/public/executor.ts @fcarreiro @dbanks12 | ||
| /yarn-project/simulator/src/public/side_effect_trace.test.ts @fcarreiro @dbanks12 | ||
| /yarn-project/simulator/src/public/side_effect_trace.ts @fcarreiro @dbanks12 | ||
| /yarn-project/simulator/src/public/side_effect_trace_interface.ts @fcarreiro @dbanks12 | ||
| /yarn-project/simulator/src/public/transitional_adaptors.ts @fcarreiro @dbanks12 | ||
| # on changes to the AVM transpiler | ||
| /avm-transpiler/src @fcarreiro @dbanks12 | ||
| ##################################################### | ||
|
|
||
|
Comment on lines
-16
to
-17
Contributor
Author
There was a problem hiding this comment. moved to top of file |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note there are multiple
generated/directories in bberg containing PIL-generated code, hence the**