Skip to content

feat: Enable merge recursive verifier in Goblin recursive verifier #7182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maramihali merged 3 commits into from
Jun 25, 2024
Merged

feat: Enable merge recursive verifier in Goblin recursive verifier #7182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6be383e
enable merge recursive verifier in goblin recursive verifier
Jun 25, 2024
3e13010
Merge branch 'master' into mm/enable-merge-recursive-verifier
Jun 25, 2024
06e6753
added issue
Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...erg/cpp/src/barretenberg/stdlib/honk_recursion/verifier/client_ivc_recursive_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

namespace bb::stdlib::recursion::honk {

/**
* @brief Performs recursive verification of the Client IVC proof.
*
* @todo (https://github.com/AztecProtocol/barretenberg/issues/934): Add logic for accumulating the pairing points
* produced by the verifiers (and potentially IPA accumulators for ECCVM verifier)
*/
void ClientIVCRecursiveVerifier::verify(const ClientIVC::Proof& proof)
{
// Perform recursive folding verification
Expand Down
4 changes: 4 additions & 0 deletions ...pp/src/barretenberg/stdlib/honk_recursion/verifier/client_ivc_recursive_verifier.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ TEST_F(ClientIVCRecursionTests, Basic)
// Generate the recursive verification circuit
verifier.verify(proof);

info("Recursive Verifier: num gates = ", builder->num_gates);

EXPECT_EQ(builder->failed(), false) << builder->err();

EXPECT_TRUE(CircuitChecker::check(*builder));
}

Expand Down
12 changes: 8 additions & 4 deletions ...tenberg/cpp/src/barretenberg/stdlib/honk_recursion/verifier/goblin_recursive_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

namespace bb::stdlib::recursion::honk {

/**
* @brief Runs the Goblin recursive verifier consisting of ECCVM, Translator and Merge verifiers.
*
* @todo https://github.com/AztecProtocol/barretenberg/issues/934: Add logic for accumulating the pairing points
* produced by the translator and merge verifier (and potentially IPA accumulators for ECCVM verifier)
*/
void GoblinRecursiveVerifier::verify(const GoblinProof& proof)
{
// Run the ECCVM recursive verifier
Expand All @@ -28,9 +34,7 @@ void GoblinRecursiveVerifier::verify(const GoblinProof& proof)
};
translator_verifier.verify_translation(translation_evaluations);

// TODO(https://github.com/AztecProtocol/barretenberg/issues/1024): Perform recursive merge verification once it
// works with Ultra arithmetization
// MergeVerifier merge_verified{ builder };
// [[maybe_unused]] auto merge_pairing_points = merge_verifier.verify_proof(proof.merge_proof);
Copy link
Contributor

@ledwards2225 ledwards2225 Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it couldn't hurt to leave this pairing points stuff or a TODO or something just to highlight that this is incomplete. Maybe there's already an issue for the general lack of aggregation handling?

MergeVerifier merge_verifier{ builder };
merge_verifier.verify_proof(proof.merge_proof);
}
} // namespace bb::stdlib::recursion::honk