Skip to content

fix: don't always run CCI#6847

Merged
ludamad merged 1 commit intomasterfrom
ad/fix-dont-always-run-cci
Jun 3, 2024
Merged

fix: don't always run CCI#6847
ludamad merged 1 commit intomasterfrom
ad/fix-dont-always-run-cci

Conversation

@ludamad
Copy link
Collaborator

@ludamad ludamad commented Jun 3, 2024

We were matching an empty tag

@ludamad ludamad enabled auto-merge (squash) June 3, 2024 21:52
@ludamad ludamad requested a review from spypsy June 3, 2024 21:54
@ludamad ludamad merged commit 63919d2 into master Jun 3, 2024
@ludamad ludamad deleted the ad/fix-dont-always-run-cci branch June 3, 2024 22:53
@AztecBot
Copy link
Collaborator

AztecBot commented Jun 3, 2024

Benchmark results

Metrics with a significant change:

  • protocol_circuit_witness_generation_time_in_ms (private-kernel-tail): 2,667 (-17%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,729 1,551 696 751 (+2%) 774
proof_construction_time_sha256_30_ms 11,787 3,152 1,409 1,443 (+1%) 1,473
proof_construction_time_sha256_100_ms 43,913 11,727 5,417 5,407 5,348
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 57.0 (-2%) 88.0
proof_construction_time_poseidon_hash_30_ms 1,523 418 202 229 (+1%) 269
proof_construction_time_poseidon_hash_100_ms 5,747 1,565 722 788 (+4%) 792

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412
l1_rollup_calldata_gas 9,476 9,446
l1_rollup_execution_gas 608,012 607,982
l2_block_processing_time_in_ms 692 1,293 (-1%)
l2_block_building_time_in_ms 22,417 (+1%) 45,964
l2_block_rollup_simulation_time_in_ms 22,296 (+1%) 45,616
l2_block_public_tx_process_time_in_ms 19,143 (+1%) 42,206

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 5,933 (-2%) 8,566 (-1%)
node_database_size_in_bytes 9,510,992 12,767,312
pxe_database_size_in_bytes 7,774 15,127

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 135 467 (-1%) 13,051 (-3%) 20,634 64,614 89,536 2,731 524,288
private-kernel-inner 404 (-1%) 944 (-1%) 50,465 (+2%) 92,326 64,614 89,536 2,731 2,097,152
private-kernel-tail 580 ⚠️ 2,667 (-17%) 52,229 96,545 68,261 11,648 297 2,097,152
base-parity 6.47 (-1%) 1,679 2,752 (-2%) 128 64.0 2,208 2.00 131,072
root-parity 49.4 (+1%) 66.4 (+7%) 40,862 (+2%) 27,100 64.0 2,720 18.0 2,097,152
base-rollup 6,017 (+1%) 2,483 (+2%) 83,164 (+4%) 119,738 756 3,648 47.0 4,194,304
root-rollup 112 (+2%) 77.6 (+1%) 22,553 (-7%) 25,309 620 3,456 41.0 1,048,576
public-kernel-app-logic 570 3,573 46,913 108,073 86,550 116,768 3,582 2,097,152
public-kernel-tail 1,139 24,225 (+1%) 183,953 403,238 7,646 11,648 297 8,388,608
private-kernel-reset-small 590 (+1%) 1,951 (-5%) 47,036 (+2%) 120,737 64,614 89,536 2,731 2,097,152
public-kernel-setup 663 2,817 (+1%) 43,371 (-3%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-teardown 566 3,611 (-1%) 46,924 (-4%) 108,073 86,550 116,768 3,582 2,097,152
merge-rollup 32.7 (+5%) N/A N/A 16,542 756 N/A N/A N/A
private-kernel-tail-to-public N/A 8,612 (+5%) 104,546 (+3%) N/A N/A 116,768 3,582 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 472 (+2%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 41.0 (-1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,764 N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 1,425 N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,883 (+1%) 16,768 53,916 (-1%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,582 (+1%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 1,042 (-4%) 16,768 10,736 (-4%) 524,288 457
Token:transfer 1,376 9,944 5,315 (-2%) 16,768 53,263 (-1%) 2,097,152 457
Benchmarking:create_note 1,344 9,944 1,472 (+5%) N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 76.5 N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,880 N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,756 (-1%) N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.4 16.9 N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.7 N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.602 0.517 (-1%) N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.5 76.1 133 247 474 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 288 543 1,055 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.496 0.469 0.455 0.448 0.443 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 58.4 113 184 (+1%) 351 628 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 107 208 355 686 1,263 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.503 0.506 0.487 0.480 0.469 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A 58.8
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A 101
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A 0.549

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 79,470 665,267

Transaction size based on fee payment method

| Metric | |
| - | |

charlielye added a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants