Merged
Conversation
This was referenced May 29, 2024
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
force-pushed
the
05-29-feat_increasing_max_public_data_update_requests_per_call_removing_hack
branch
from
62a84c6 to
a179be0
Compare
Base automatically changed from
05-29-feat_increasing_max_public_data_update_requests_per_call_removing_hack
to
master
May 30, 2024 07:05
benesjan
force-pushed
the
05-29-refactor_nuking_broadcast_param
branch
from
03a4250 to
294ed0a
Compare
benesjan
changed the base branch from
master
to
05-29-refactor_cleanup_after_outgoing
benesjan
force-pushed
the
05-29-refactor_nuking_broadcast_param
branch
from
72ccf2a to
456cc77
Compare
LHerskind
approved these changes
May 30, 2024
Contributor
LHerskind
left a comment
LHerskind
left a comment
There was a problem hiding this comment.
Mostly looks good, an extra comment would be good 👍 After that, good from me
| fn set_constant(value: Field) { | ||
| let mut note = TestNote::new(value); | ||
| storage.example_constant.initialize(&mut note, false, GrumpkinPoint::zero(), GrumpkinPoint::zero()); | ||
| storage.example_constant.initialize(&mut note, GrumpkinPoint::zero(), GrumpkinPoint::zero()); |
Contributor
There was a problem hiding this comment.
I think it would be nice to add a small comment here that we are not failing because the testnote is never broadcast. It is in the note itself, but this would usually cause a failure if actually broadcasting 🤷
| // Add the note | ||
| const note = new Note([new Fr(value)]); | ||
|
|
||
| // We have to manually add the note because the note ciphertext is encrypted with zero keys since there |
Contributor
There was a problem hiding this comment.
See comment earlier related to the test_contract. It is not actually encrypted, it is not broadcast.
benesjan
force-pushed
the
05-29-refactor_nuking_broadcast_param
branch
from
c998e60 to
283507d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6440