Skip to content

chore(ci): better retry defaults #6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 3 commits into from
May 16, 2024
Merged

chore(ci): better retry defaults #6472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f654ce
ci-consistency as external check
ludamad May 16, 2024
8903009
spot retry fix
ludamad May 16, 2024
1fa3bc7
Merge branch 'master' into ad/spot-retry-fix
ludamad May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/spot-runner-action/dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ class Ec2Instance {
this.client = new aws_sdk_1.default.EC2({
credentials: credentials,
region: this.config.awsRegion,
maxRetries: 3,
// base 10 seconds for the exponential backoff, up to 3 times
retryDelayOptions: { base: 10000 }
});
}
return this.client;
Expand Down
3 changes: 3 additions & 0 deletions .github/spot-runner-action/src/ec2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ export class Ec2Instance {
this.client = new AWS.EC2({
credentials: credentials,
region: this.config.awsRegion,
maxRetries: 3,
// base 10 seconds for the exponential backoff, up to 3 times
retryDelayOptions: {base: 10000}
Comment on lines +54 to +56
Copy link
Contributor

@spalladino spalladino May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update the constructor in L39-L42?

Copy link
Collaborator Author

@ludamad ludamad May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh this (inherited) code makes no sense, but yeah looks like it :)

Copy link
Collaborator Author

@ludamad ludamad May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see it's for some feature we aren't using, I updated the less important one

Copy link
Collaborator Author

@ludamad ludamad May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

});
}
return this.client;
Expand Down