Skip to content

fix: don't start multiple runners during RequestLimitExceeded #6444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 2 commits into from
May 15, 2024
Merged

fix: don't start multiple runners during RequestLimitExceeded #6444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6626645
Check for runners
ludamad May 15, 2024
9fd94c0
fix
ludamad May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/spot-runner-action/dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,7 @@ function pollSpotStatus(config, ec2Client, ghClient) {
});
}
function requestAndWaitForSpot(config) {
var _a;
return __awaiter(this, void 0, void 0, function* () {
// subaction is 'start' or 'restart'estart'
const ec2Client = new ec2_1.Ec2Instance(config);
Expand Down Expand Up @@ -747,9 +748,11 @@ function requestAndWaitForSpot(config) {
// wait 10 seconds
yield new Promise((r) => setTimeout(r, 5000 * Math.pow(2, backoff)));
backoff += 1;
core.info("Polling to see if we somehow have an instance up");
instanceId = yield ((_a = ec2Client.getInstancesForTags("running")[0]) === null || _a === void 0 ? void 0 : _a.instanceId);
}
if (instanceId) {
core.info("Successfully requested instance with ID " + instanceId);
core.info("Successfully requested/found instance with ID " + instanceId);
break;
}
}
Expand Down
4 changes: 3 additions & 1 deletion .github/spot-runner-action/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,11 @@ async function requestAndWaitForSpot(config: ActionConfig): Promise<string> {
// wait 10 seconds
await new Promise((r) => setTimeout(r, 5000 * 2 ** backoff));
backoff += 1;
core.info("Polling to see if we somehow have an instance up");
instanceId = await ec2Client.getInstancesForTags("running")[0]?.instanceId;
}
if (instanceId) {
core.info("Successfully requested instance with ID " + instanceId);
core.info("Successfully requested/found instance with ID " + instanceId);
break;
}
}
Expand Down