feat(avm-simulator): make storage work across enqueued calls#6181
Merged
feat(avm-simulator): make storage work across enqueued calls#6181
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @fcarreiro and the rest of your teammates on |
fcarreiro
force-pushed
the
fc/avm-storage-across-enqueued-calls
branch
2 times, most recently
from
d966123 to
f29b328
Compare
dbanks12
approved these changes
May 3, 2024
Contributor
dbanks12
left a comment
dbanks12
left a comment
There was a problem hiding this comment.
LGTM! Let's wait to merge until my stack is merged.
dbanks12
reviewed
May 3, 2024
Contributor
dbanks12
left a comment
dbanks12
left a comment
There was a problem hiding this comment.
Wondering if it would be cleaner to (maybe later / in another PR) do something similar to nullifiers and maybe initialize an enqueued calls's PublicStorage with the previous enqueued call's as a parent?
fcarreiro
force-pushed
the
fc/avm-storage-across-enqueued-calls
branch
from
f29b328 to
b9acabf
Compare
fcarreiro
force-pushed
the
fc/avm-storage-across-enqueued-calls
branch
from
62043e0 to
46c74f8
Compare
Contributor
Author
Merge activity
|
This was referenced May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.