Skip to content

fix: increase default number of proving agents #6146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexghr merged 4 commits into from
May 3, 2024
Merged

fix: increase default number of proving agents #6146

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
262ee2f
feat: add proving retries
May 2, 2024
37edb1d
fix: increase default number of proving agents
May 2, 2024
58b56c8
Merge branch 'master' into 05-02-fix_increase_default_number_of_provi…
PhilWindle May 3, 2024
4038202
fix: increase default number of proving agents
May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion yarn-project/prover-client/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function getProverEnvVars(): ProverConfig {
ACVM_BINARY_PATH = '',
BB_WORKING_DIRECTORY = tmpdir(),
BB_BINARY_PATH = '',
PROVER_AGENTS = '1',
PROVER_AGENTS = '10',

@PhilWindle PhilWindle May 3, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should set this default here. I'm always mindful that defaults should be a value that would make sense in a production setting. Can we not just set this for test runs?

PROVER_REAL_PROOFS = '',
} = process.env;

Expand Down
3 changes: 3 additions & 0 deletions yarn-project/prover-client/src/prover-pool/prover-pool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { type ProvingJobSource } from '@aztec/circuit-types';
import { sleep } from '@aztec/foundation/sleep';
import { type SimulationProvider } from '@aztec/simulator';

import { mkdtemp } from 'fs/promises';
Expand Down Expand Up @@ -33,6 +34,8 @@ export class ProverPool {

for (const agent of this.agents) {
agent.start(source);
// stagger that start of each agent to avoid contention
await sleep(10);
}
}

Expand Down
4 changes: 2 additions & 2 deletions yarn-project/prover-client/src/tx-prover/tx-prover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ export class TxProver implements ProverClient {
throw new Error();
}

pool = ProverPool.nativePool(config, config.proverAgents, 10);
pool = ProverPool.nativePool(config, config.proverAgents, 50);
} else {
pool = ProverPool.testPool(simulationProvider, config.proverAgents, 10);
pool = ProverPool.testPool(simulationProvider, config.proverAgents, 50);
}

const prover = new TxProver(worldStateSynchronizer, getVerificationKeys(), pool);
Expand Down