feat(sandbox): auto transpile public contract functions in sandbox#6140
feat(sandbox): auto transpile public contract functions in sandbox#6140
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
b394e51 to
12922ea
Compare
charlielye
left a comment
There was a problem hiding this comment.
TLDR I think best approach is (open to discussion):
- Create new
aztec-nargoat top level of repo. - Create Earthfile that creates image
aztecprotocol/aztec-nargothat contains both noir bin and transpiler bin and wrapper script with wrapper as entrypoint. - Release that instead of current two containers.
- Update the aztec-up wrapper script to run
aztecprotocol/aztec-nargoinstead ofaztecprotocol/noir.
*If this isn't being released immediately, save yourself having to do Dockerfile and old CI work. Liase with Phil about when we can do releases from Earthly GA.
42480d9 to
93ed10e
Compare
d8da6da to
f6b6f33
Compare
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | |
dbanks12
left a comment
There was a problem hiding this comment.
Do I need to add an entry to build-ci in top-level Earthfile? This image isn't used by any CI jobs. It is only for the end user.
02ff074 to
5622033
Compare
fc8814b to
3eb498f
Compare
5622033 to
e7513c0
Compare
ludamad
left a comment
There was a problem hiding this comment.
LGTM other than earthfile not currently being used in ci.yml or otherwise, seems likely to coderot
Fair enough regarding code rot! I know that we're gearing up for a shift to Earthly GA releases, so I wanted to make sure I did the legwork there too. |
Addressed all of charlie's concerns and got approval from @ludamad

No description provided.