Skip to content

fix: fix relation skipping for sumcheck #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ledwards2225 merged 2 commits into from
Apr 29, 2024
Merged

fix: fix relation skipping for sumcheck #6092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b72ffda
fix skipping
ledwards2225 Apr 29, 2024
70d1e14
Merge branch 'master' into lde/fix_skipping
ledwards2225 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/relations/relation_types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ consteval std::array<size_t, NUM_SUBRELATIONS> compute_composed_subrelation_part
template <typename Relation, typename AllEntities>
concept isSkippable = requires(const AllEntities& input) {
{
Relation::is_active(input)
Relation::skip(input)
} -> std::same_as<bool>;
};

Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/sumcheck/sumcheck_round.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ template <typename Flavor> class SumcheckProverRound {
std::get<relation_idx>(univariate_accumulators), extended_edges, relation_parameters, scaling_factor);
} else {
// If so, only compute the contribution if the relation is active
if (!Relation::skip(extended_edges, relation_parameters)) {
if (!Relation::skip(extended_edges)) {
Relation::accumulate(std::get<relation_idx>(univariate_accumulators),
extended_edges,
relation_parameters,
Expand Down