Skip to content

chore: revert "chore: don't strip bb wasm" #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ludamad wants to merge 2 commits into from
Closed

chore: revert "chore: don't strip bb wasm" #6068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a07cdf9
Revert "chore: don't strip bb wasm (#5743)"
ludamad Apr 26, 2024
179c3f2
Merge branch 'master' into revert-5743-ad/dont-strip-bb-wasm
ludamad Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions barretenberg/cpp/Earthfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ preset-wasm-threads:
FROM +source
COPY +get-wasi-sdk-threads/wasi-sdk src/wasi-sdk
RUN cmake --preset wasm-threads -Bbuild && cmake --build build --target barretenberg.wasm
# TODO(https://github.com/AztecProtocol/barretenberg/issues/941) We currently do not strip barretenberg threaded wasm, for stack traces.
# RUN src/wasi-sdk/bin/llvm-strip ./build/bin/barretenberg.wasm
RUN src/wasi-sdk/bin/llvm-strip ./build/bin/barretenberg.wasm
SAVE ARTIFACT build/bin

preset-gcc:
Expand Down
3 changes: 1 addition & 2 deletions barretenberg/cpp/scripts/strip-wasm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#!/bin/sh
./src/wasi-sdk-20.0/bin/llvm-strip ./build-wasm/bin/barretenberg.wasm
# TODO(https://github.com/AztecProtocol/barretenberg/issues/941) We currently do not strip barretenberg threaded wasm, for stack traces.
# ./src/wasi-sdk-20.0/bin/llvm-strip ./build-wasm-threads/bin/barretenberg.wasm
./src/wasi-sdk-20.0/bin/llvm-strip ./build-wasm-threads/bin/barretenberg.wasm
2 changes: 1 addition & 1 deletion barretenberg/ts/scripts/build_wasm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ fi
mkdir -p ./dest/node/barretenberg_wasm
mkdir -p ./dest/node-cjs/barretenberg_wasm
cp ../cpp/build-wasm-threads/bin/barretenberg.wasm ./dest/node/barretenberg_wasm/barretenberg-threads.wasm
cp ../cpp/build-wasm-threads/bin/barretenberg.wasm ./dest/node-cjs/barretenberg_wasm/barretenberg-threads.wasm
cp ../cpp/build-wasm-threads/bin/barretenberg.wasm ./dest/node-cjs/barretenberg_wasm/barretenberg-threads.wasm