Skip to content

feat: Optimize auxiliary relations slightly #5517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rumata888 merged 2 commits into from
Apr 2, 2024
Merged

feat: Optimize auxiliary relations slightly #5517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1127993
remove unnecessary multiplications
Rumata888 Mar 29, 2024
401e9c5
Merge branch 'master' into is/mini_auxiliary_optimization
Rumata888 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions barretenberg/cpp/src/barretenberg/relations/auxiliary_relation.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ template <typename FF_> class AuxiliaryRelationImpl {

auto index_is_monotonically_increasing = index_delta * index_delta - index_delta; // deg 2

auto adjacent_values_match_if_adjacent_indices_match = (index_delta * FF(-1) + FF(1)) * record_delta; // deg 2
auto adjacent_values_match_if_adjacent_indices_match = (-index_delta + FF(1)) * record_delta; // deg 2

std::get<1>(accumulators) +=
adjacent_values_match_if_adjacent_indices_match * (q_1 * q_2) * (q_aux * scaling_factor); // deg 5
Expand Down Expand Up @@ -286,7 +286,7 @@ template <typename FF_> class AuxiliaryRelationImpl {

auto value_delta = w_3_shift - w_3;
auto adjacent_values_match_if_adjacent_indices_match_and_next_access_is_a_read_operation =
(index_delta * FF(-1) + FF(1)) * value_delta * (next_gate_access_type * FF(-1) + FF(1)); // deg 3 or 4
(-index_delta + FF(1)) * value_delta * (-next_gate_access_type + FF(1)); // deg 3 or 4

// We can't apply the RAM consistency check identity on the final entry in the sorted list (the wires in the
// next gate would make the identity fail). We need to validate that its 'access type' bool is correct. Can't
Expand Down Expand Up @@ -316,7 +316,7 @@ template <typename FF_> class AuxiliaryRelationImpl {
* Else timestamp_check = 0
*/
auto timestamp_delta = w_2_shift - w_2;
auto RAM_timestamp_check_identity = (index_delta * FF(-1) + FF(1)) * timestamp_delta - w_3; // deg 3
auto RAM_timestamp_check_identity = (-index_delta + FF(1)) * timestamp_delta - w_3; // deg 3

/**
* The complete RAM/ROM memory identity
Expand Down