Skip to content

fix: login to dockerhub before 'docker compose' #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 2 commits into from
Mar 25, 2024
Merged

fix: login to dockerhub before 'docker compose' #5440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddab6de
fix: login to dockerhub before 'docker compose'
ludamad Mar 25, 2024
d6153ea
Update cond_run_compose
ludamad Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build-system/scripts/cond_run_compose
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ SUCCESS_TAG=$BASE_TAG-$JOB_NAME
echo "Success tag: $SUCCESS_TAG"

if ! check_rebuild $SUCCESS_TAG $REPOSITORY; then
# Login to pull our ecr images with docker.
# Login to pull our images from ecr or dockerhub.
retry ecr_login
retry dockerhub_login

# For each dependency and self, pull in the latest image and give it correct tag.
for REPO in $(query_manifest runDependencies $REPOSITORY $JOB_NAME); do
Expand Down