fix: Docs links URL missing a letter#5223
Merged
spalladino merged 1 commit intomasterfrom Mar 14, 2024
Merged
Conversation
critesjosh
approved these changes
Mar 14, 2024
Contributor
Author
|
Ah, found the culprit: |
Collaborator
Docs PreviewHey there! 👋 You can check your preview at https://65f35b665c5215220da4c58d--aztec-docs-dev.netlify.app |
critesjosh
pushed a commit
that referenced
this pull request
Mar 15, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.28.1</summary> ## [0.28.1](aztec-package-v0.28.0...aztec-package-v0.28.1) (2024-03-14) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.28.1</summary> ## [0.28.1](barretenberg.js-v0.28.0...barretenberg.js-v0.28.1) (2024-03-14) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.28.1</summary> ## [0.28.1](aztec-cli-v0.28.0...aztec-cli-v0.28.1) (2024-03-14) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.28.1</summary> ## [0.28.1](aztec-packages-v0.28.0...aztec-packages-v0.28.1) (2024-03-14) ### Bug Fixes * Docs links URL missing a letter ([#5223](#5223)) ([c015a3f](c015a3f)) * **docs:** Update other constructor refs in docs to use initializer ([#5227](#5227)) ([f68ff28](f68ff28)) ### Miscellaneous * **docs:** Add note on new initializer ([#5224](#5224)) ([79c6e99](79c6e99)) </details> <details><summary>barretenberg: 0.28.1</summary> ## [0.28.1](barretenberg-v0.28.0...barretenberg-v0.28.1) (2024-03-14) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Mar 15, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.28.1</summary> ## [0.28.1](AztecProtocol/aztec-packages@aztec-package-v0.28.0...aztec-package-v0.28.1) (2024-03-14) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.28.1</summary> ## [0.28.1](AztecProtocol/aztec-packages@barretenberg.js-v0.28.0...barretenberg.js-v0.28.1) (2024-03-14) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.28.1</summary> ## [0.28.1](AztecProtocol/aztec-packages@aztec-cli-v0.28.0...aztec-cli-v0.28.1) (2024-03-14) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.28.1</summary> ## [0.28.1](AztecProtocol/aztec-packages@aztec-packages-v0.28.0...aztec-packages-v0.28.1) (2024-03-14) ### Bug Fixes * Docs links URL missing a letter ([#5223](AztecProtocol/aztec-packages#5223)) ([c015a3f](AztecProtocol/aztec-packages@c015a3f)) * **docs:** Update other constructor refs in docs to use initializer ([#5227](AztecProtocol/aztec-packages#5227)) ([f68ff28](AztecProtocol/aztec-packages@f68ff28)) ### Miscellaneous * **docs:** Add note on new initializer ([#5224](AztecProtocol/aztec-packages#5224)) ([79c6e99](AztecProtocol/aztec-packages@79c6e99)) </details> <details><summary>barretenberg: 0.28.1</summary> ## [0.28.1](AztecProtocol/aztec-packages@barretenberg-v0.28.0...barretenberg-v0.28.1) (2024-03-14) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sklppy88
pushed a commit
that referenced
this pull request
Mar 15, 2024
Seems like COMMIT_TAG strips the leading `v` as well. This seems to contradict what we're seeing here, but oh well. https://github.com/AztecProtocol/aztec-packages/blob/37bdc1820f92ad2cc545e6843a0dd90273c21e0e/build-system/scripts/setup_env#L17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like COMMIT_TAG strips the leading
vas well. This seems to contradict what we're seeing here, but oh well.aztec-packages/build-system/scripts/setup_env
Line 17 in 37bdc18