Skip to content

feat: Sync from noir#5063

Closed
AztecBot wants to merge 2 commits intomasterfrom
sync-noir
Closed

feat: Sync from noir#5063
AztecBot wants to merge 2 commits intomasterfrom
sync-noir

Conversation

@AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Mar 7, 2024

BEGIN_COMMIT_OVERRIDE
Development from noir
chore: add regression test for issue 4449 (noir-lang/noir#4503)
chore: pass macro processors by reference (noir-lang/noir#4501)
chore: bump bb to 0.26.3 (noir-lang/noir#4488)
fix: handling of gh deps in noir_wasm (noir-lang/noir#4499)
fix: iterative flattening pass (noir-lang/noir#4492)
chore: Move templated code for assert_message into the stdlib (noir-lang/noir#4475)
chore: pull out separate function for compiling and running a test
chore: update cargo deny config (noir-lang/noir#4486)
feat: run tests in parallel in nargo test (noir-lang/noir#4484)
END_COMMIT_OVERRIDE

AztecBot added 2 commits March 7, 2024 19:49
chore: pass macro processors by reference (noir-lang/noir#4501)
chore: bump bb to 0.26.3 (noir-lang/noir#4488)
fix: handling of gh deps in noir_wasm (noir-lang/noir#4499)
fix: iterative flattening pass (noir-lang/noir#4492)
chore: Move templated code for assert_message into the stdlib (noir-lang/noir#4475)
chore: pull out separate function for compiling and running a test
chore: update cargo deny config (noir-lang/noir#4486)
feat: run tests in parallel in `nargo test`  (noir-lang/noir#4484)
subrepo:
  subdir:   "noir/noir-repo"
  merged:   "2a555a041"
upstream:
  origin:   "https://github.com/noir-lang/noir"
  branch:   "master"
  commit:   "2a555a041"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
@ludamad ludamad closed this Mar 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Changes to circuit sizes

Generated at commit: d28636646c0e786b5b30effc9606a94d39119774, compared to commit: fed729daaa667b78e9291a9eae5ab8225f82d572

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init +2,221 ❌ +4.69% +2,221 ❌ +0.62%
rollup_base +10,497 ❌ +6.49% +10,497 ❌ +0.61%
private_kernel_inner +2,224 ❌ +2.35% +2,224 ❌ +0.42%
public_kernel_app_logic +582 ❌ +1.08% +582 ❌ +0.19%
public_kernel_setup +191 ❌ +0.71% +191 ❌ +0.11%
public_kernel_teardown +191 ❌ +0.67% +191 ❌ +0.11%
private_kernel_tail +328 ❌ +0.09% +328 ❌ +0.04%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init 49,528 (+2,221) +4.69% 359,331 (+2,221) +0.62%
rollup_base 172,123 (+10,497) +6.49% 1,744,091 (+10,497) +0.61%
private_kernel_inner 96,866 (+2,224) +2.35% 531,002 (+2,224) +0.42%
public_kernel_app_logic 54,569 (+582) +1.08% 308,675 (+582) +0.19%
public_kernel_setup 26,907 (+191) +0.71% 176,935 (+191) +0.11%
public_kernel_teardown 28,608 (+191) +0.67% 178,637 (+191) +0.11%
private_kernel_tail 373,493 (+328) +0.09% 839,611 (+328) +0.04%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants