feat(avm-simulator): external calls + integration by fcarreiro · Pull Request #5051 · AztecProtocol/aztec-packages

fcarreiro · 2024-03-07T16:23:40Z

This PR finishes the external call opcodes, adds the necessary aztec.nr machinery and tests. It's based on David's work.

Relates to #4313, #4127.

fcarreiro · 2024-03-07T16:23:55Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

AztecBot · 2024-03-07T17:42:49Z

Benchmark results

Metrics with a significant change:

circuit_simulation_time_in_ms (private-kernel-inner): 367 (+16%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 8b106001 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,396	239,360	470,372
l1_rollup_execution_gas	673,859	980,181	1,389,146
l2_block_processing_time_in_ms	1,319 (-1%)	4,783 (-2%)	9,252 (+4%)
note_successful_decrypting_time_in_ms	154 (+13%)	479	942 (-1%)
note_trial_decrypting_time_in_ms	59.8 (+47%)	96.1	72.5 (-7%)
l2_block_building_time_in_ms	12,875 (+5%)	50,645 (+6%)	101,575 (+7%)
l2_block_rollup_simulation_time_in_ms	7,621 (+2%)	30,124 (+3%)	60,678 (+4%)
l2_block_public_tx_process_time_in_ms	5,223 (+11%)	20,456 (+12%)	40,754 (+12%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,050	27,140 (+2%)
note_history_successful_decrypting_time_in_ms	1,200 (-7%)	2,492 (+4%)
note_history_trial_decrypting_time_in_ms	69.2 (-31%)	223 (+54%)
node_database_size_in_bytes	18,849,872	35,594,320 (+1%)
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	282 (+13%)	44,736	28,001
private-kernel-ordering	209 (+8%)	52,625	14,627
base-rollup	682 (+4%)	177,932	997
root-rollup	68.7	4,320	825
private-kernel-inner	⚠️ 367 (+16%)	73,715	28,001
public-kernel-app-logic	189 (+17%)	34,920	27,972
public-kernel-tail	92.5 (+14%)	34,507	27,972
merge-rollup	8.50 (+2%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.84 (+2%)	11.1 (+9%)	12.2 (-1%)	16.1 (+1%)	22.0 (-1%)	43.4 (+27%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.572 (+2%)	0.616 (+10%)	0.519	0.498 (+1%)	0.462 (-1%)	0.542 (+27%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	46.0 (+2%)	71.6 (-1%)	229	446 (+3%)	863 (-1%)	1,708 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.472 (+2%)	0.443 (-1%)	0.419	0.418 (+3%)	0.411 (-1%)	0.410 (+2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	53.9	106	334 (-1%)	657 (+2%)	1,307	2,591 (+3%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.480 (-1%)	0.480 (+1%)	0.455 (-1%)	0.453 (+2%)	0.453	0.452 (+3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.0 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.534 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,650

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,954 (+8%)	1,474 (+8%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	7.40 (-5%)	635 (+12%)

noir-projects/aztec-nr/aztec/src/context/avm.nr

avm-transpiler/src/transpile.rs

Maddiaa0 · 2024-03-09T16:47:55Z

avm-transpiler/src/transpile.rs

+        ValueOrArray::HeapVector(_) => panic!("Call instruction's args must be a HeapArray, not a HeapVector. Make sure you are explicitly defining its size (`[arg0, arg1, ... argN]`)!"),
+        _ => panic!("Call instruction's args input should be a HeapArray input"),
+    };
+    let temporary_function_selector_offset = match &inputs[3] {


inconsistency in not using _maybe here. Im in favor of purging the _maybe from the entire file in a followup

Ok! Let's do later.

Maddiaa0 · 2024-03-09T16:51:35Z

avm-transpiler/src/transpile.rs

+    };
+    avm_instrs.push(AvmInstruction {
+        opcode: AvmOpcode::CALL,
+        indirect: Some(0b01101), // (left to right) selector direct, ret offset INDIRECT, args offset INDIRECT, address offset direct, gas offset INDIRECT


@IlyasRidhuan heres a fun indirect problem to think about

Maddiaa0

Very nice

fcarreiro · 2024-03-11T10:51:45Z

Merge activity

Mar 11, 6:51 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
Mar 11, 6:55 AM EDT: @fcarreiro merged this pull request with Graphite.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.0</summary> ## [0.27.0](aztec-package-v0.26.6...aztec-package-v0.27.0) (2024-03-12) ### Features * Add api for inclusion proof of outgoing message in block [#4562](#4562) ([#4899](#4899)) ([26d2643](26d2643)) ### Miscellaneous * Pin foundry ([#5151](#5151)) ([69bd7dd](69bd7dd)) * Remove old contract deployment flow ([#4970](#4970)) ([6d15947](6d15947)) </details> <details><summary>barretenberg.js: 0.27.0</summary> ## [0.27.0](barretenberg.js-v0.26.6...barretenberg.js-v0.27.0) (2024-03-12) ### Miscellaneous * Move alpine containers to ubuntu ([#5026](#5026)) ([d483e67](d483e67)), closes [#4708](#4708) </details> <details><summary>aztec-cli: 0.27.0</summary> ## [0.27.0](aztec-cli-v0.26.6...aztec-cli-v0.27.0) (2024-03-12) ### Miscellaneous * Remove old contract deployment flow ([#4970](#4970)) ([6d15947](6d15947)) </details> <details><summary>aztec-packages: 0.27.0</summary> ## [0.27.0](aztec-packages-v0.26.6...aztec-packages-v0.27.0) (2024-03-12) ### ⚠ BREAKING CHANGES * Remove open keyword from Noir ([#4967](#4967)) ### Features * Add api for inclusion proof of outgoing message in block [#4562](#4562) ([#4899](#4899)) ([26d2643](26d2643)) * **avm-simulator:** External calls + integration ([#5051](#5051)) ([dde33f4](dde33f4)) * **avm-simulator:** External static calls + integration ([#5089](#5089)) ([428d950](428d950)) * **avm:** Equivalence check between Main trace and Mem trace ([#5032](#5032)) ([7f216eb](7f216eb)), closes [#4955](#4955) * **avm:** Fix some Brillig problems ([#5091](#5091)) ([07dd821](07dd821)) * Initial integration avm prover ([#4878](#4878)) ([2e2554e](2e2554e)) * Noir pull action ([#5062](#5062)) ([b2d7d14](b2d7d14)) * Restore contract inclusion proofs ([#5141](#5141)) ([a39cd61](a39cd61)) * Update the core of SMT Circuit class ([#5096](#5096)) ([1519d3b](1519d3b)) * Updating archiver with new inbox ([#5025](#5025)) ([f6d17c9](f6d17c9)), closes [#4828](#4828) ### Bug Fixes * Duplicate factory code temporarily to unblock ([#5099](#5099)) ([8b10600](8b10600)) * Remove hard coded canonical gas address ([#5106](#5106)) ([dc2fd9e](dc2fd9e)) ### Miscellaneous * **avm-simulator:** Enable compressed strings unencrypted log test ([#5083](#5083)) ([8f7519b](8f7519b)) * **avm-simulator:** Formatting and fixes ([#5092](#5092)) ([b3fa084](b3fa084)) * **AVM:** Negative unit tests for inter table relations ([#5143](#5143)) ([a74dccb](a74dccb)), closes [#5033](#5033) * Aztec-macros refactor ([#5127](#5127)) ([2195441](2195441)) * **ci:** Fail on clippy warnings in noir ([#5101](#5101)) ([54af648](54af648)) * Extract bb binary in bs fast ([#5128](#5128)) ([9ca41ef](9ca41ef)) * Increase bytecode size limit ([#5098](#5098)) ([53b2381](53b2381)) * Increase permitted bytecode size ([#5136](#5136)) ([6865c34](6865c34)) * Join-split example Part 2 ([#5016](#5016)) ([0718320](0718320)) * Move alpine containers to ubuntu ([#5026](#5026)) ([d483e67](d483e67)), closes [#4708](#4708) * Nicer snapshots ([#5133](#5133)) ([9a737eb](9a737eb)) * Pin foundry ([#5151](#5151)) ([69bd7dd](69bd7dd)) * Remove old contract deployment flow ([#4970](#4970)) ([6d15947](6d15947)) * Remove open keyword from Noir ([#4967](#4967)) ([401557e](401557e)) * Run nargo fmt on each nargo project ([#5102](#5102)) ([b327254](b327254)) * Use context interface in mark-as-initialized ([#5142](#5142)) ([932c1d5](932c1d5)) </details> <details><summary>barretenberg: 0.27.0</summary> ## [0.27.0](barretenberg-v0.26.6...barretenberg-v0.27.0) (2024-03-12) ### Features * **avm:** Equivalence check between Main trace and Mem trace ([#5032](#5032)) ([7f216eb](7f216eb)), closes [#4955](#4955) * Initial integration avm prover ([#4878](#4878)) ([2e2554e](2e2554e)) * Update the core of SMT Circuit class ([#5096](#5096)) ([1519d3b](1519d3b)) ### Miscellaneous * **AVM:** Negative unit tests for inter table relations ([#5143](#5143)) ([a74dccb](a74dccb)), closes [#5033](#5033) * Extract bb binary in bs fast ([#5128](#5128)) ([9ca41ef](9ca41ef)) * Join-split example Part 2 ([#5016](#5016)) ([0718320](0718320)) * Move alpine containers to ubuntu ([#5026](#5026)) ([d483e67](d483e67)), closes [#4708](#4708) * Pin foundry ([#5151](#5151)) ([69bd7dd](69bd7dd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@aztec-package-v0.26.6...aztec-package-v0.27.0) (2024-03-12) ### Features * Add api for inclusion proof of outgoing message in block [#4562](AztecProtocol/aztec-packages#4562) ([#4899](AztecProtocol/aztec-packages#4899)) ([26d2643](AztecProtocol/aztec-packages@26d2643)) ### Miscellaneous * Pin foundry ([#5151](AztecProtocol/aztec-packages#5151)) ([69bd7dd](AztecProtocol/aztec-packages@69bd7dd)) * Remove old contract deployment flow ([#4970](AztecProtocol/aztec-packages#4970)) ([6d15947](AztecProtocol/aztec-packages@6d15947)) </details> <details><summary>barretenberg.js: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@barretenberg.js-v0.26.6...barretenberg.js-v0.27.0) (2024-03-12) ### Miscellaneous * Move alpine containers to ubuntu ([#5026](AztecProtocol/aztec-packages#5026)) ([d483e67](AztecProtocol/aztec-packages@d483e67)), closes [#4708](AztecProtocol/aztec-packages#4708) </details> <details><summary>aztec-cli: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@aztec-cli-v0.26.6...aztec-cli-v0.27.0) (2024-03-12) ### Miscellaneous * Remove old contract deployment flow ([#4970](AztecProtocol/aztec-packages#4970)) ([6d15947](AztecProtocol/aztec-packages@6d15947)) </details> <details><summary>aztec-packages: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@aztec-packages-v0.26.6...aztec-packages-v0.27.0) (2024-03-12) ### ⚠ BREAKING CHANGES * Remove open keyword from Noir ([#4967](AztecProtocol/aztec-packages#4967)) ### Features * Add api for inclusion proof of outgoing message in block [#4562](AztecProtocol/aztec-packages#4562) ([#4899](AztecProtocol/aztec-packages#4899)) ([26d2643](AztecProtocol/aztec-packages@26d2643)) * **avm-simulator:** External calls + integration ([#5051](AztecProtocol/aztec-packages#5051)) ([dde33f4](AztecProtocol/aztec-packages@dde33f4)) * **avm-simulator:** External static calls + integration ([#5089](AztecProtocol/aztec-packages#5089)) ([428d950](AztecProtocol/aztec-packages@428d950)) * **avm:** Equivalence check between Main trace and Mem trace ([#5032](AztecProtocol/aztec-packages#5032)) ([7f216eb](AztecProtocol/aztec-packages@7f216eb)), closes [#4955](AztecProtocol/aztec-packages#4955) * **avm:** Fix some Brillig problems ([#5091](AztecProtocol/aztec-packages#5091)) ([07dd821](AztecProtocol/aztec-packages@07dd821)) * Initial integration avm prover ([#4878](AztecProtocol/aztec-packages#4878)) ([2e2554e](AztecProtocol/aztec-packages@2e2554e)) * Noir pull action ([#5062](AztecProtocol/aztec-packages#5062)) ([b2d7d14](AztecProtocol/aztec-packages@b2d7d14)) * Restore contract inclusion proofs ([#5141](AztecProtocol/aztec-packages#5141)) ([a39cd61](AztecProtocol/aztec-packages@a39cd61)) * Update the core of SMT Circuit class ([#5096](AztecProtocol/aztec-packages#5096)) ([1519d3b](AztecProtocol/aztec-packages@1519d3b)) * Updating archiver with new inbox ([#5025](AztecProtocol/aztec-packages#5025)) ([f6d17c9](AztecProtocol/aztec-packages@f6d17c9)), closes [#4828](AztecProtocol/aztec-packages#4828) ### Bug Fixes * Duplicate factory code temporarily to unblock ([#5099](AztecProtocol/aztec-packages#5099)) ([8b10600](AztecProtocol/aztec-packages@8b10600)) * Remove hard coded canonical gas address ([#5106](AztecProtocol/aztec-packages#5106)) ([dc2fd9e](AztecProtocol/aztec-packages@dc2fd9e)) ### Miscellaneous * **avm-simulator:** Enable compressed strings unencrypted log test ([#5083](AztecProtocol/aztec-packages#5083)) ([8f7519b](AztecProtocol/aztec-packages@8f7519b)) * **avm-simulator:** Formatting and fixes ([#5092](AztecProtocol/aztec-packages#5092)) ([b3fa084](AztecProtocol/aztec-packages@b3fa084)) * **AVM:** Negative unit tests for inter table relations ([#5143](AztecProtocol/aztec-packages#5143)) ([a74dccb](AztecProtocol/aztec-packages@a74dccb)), closes [#5033](AztecProtocol/aztec-packages#5033) * Aztec-macros refactor ([#5127](AztecProtocol/aztec-packages#5127)) ([2195441](AztecProtocol/aztec-packages@2195441)) * **ci:** Fail on clippy warnings in noir ([#5101](AztecProtocol/aztec-packages#5101)) ([54af648](AztecProtocol/aztec-packages@54af648)) * Extract bb binary in bs fast ([#5128](AztecProtocol/aztec-packages#5128)) ([9ca41ef](AztecProtocol/aztec-packages@9ca41ef)) * Increase bytecode size limit ([#5098](AztecProtocol/aztec-packages#5098)) ([53b2381](AztecProtocol/aztec-packages@53b2381)) * Increase permitted bytecode size ([#5136](AztecProtocol/aztec-packages#5136)) ([6865c34](AztecProtocol/aztec-packages@6865c34)) * Join-split example Part 2 ([#5016](AztecProtocol/aztec-packages#5016)) ([0718320](AztecProtocol/aztec-packages@0718320)) * Move alpine containers to ubuntu ([#5026](AztecProtocol/aztec-packages#5026)) ([d483e67](AztecProtocol/aztec-packages@d483e67)), closes [#4708](AztecProtocol/aztec-packages#4708) * Nicer snapshots ([#5133](AztecProtocol/aztec-packages#5133)) ([9a737eb](AztecProtocol/aztec-packages@9a737eb)) * Pin foundry ([#5151](AztecProtocol/aztec-packages#5151)) ([69bd7dd](AztecProtocol/aztec-packages@69bd7dd)) * Remove old contract deployment flow ([#4970](AztecProtocol/aztec-packages#4970)) ([6d15947](AztecProtocol/aztec-packages@6d15947)) * Remove open keyword from Noir ([#4967](AztecProtocol/aztec-packages#4967)) ([401557e](AztecProtocol/aztec-packages@401557e)) * Run nargo fmt on each nargo project ([#5102](AztecProtocol/aztec-packages#5102)) ([b327254](AztecProtocol/aztec-packages@b327254)) * Use context interface in mark-as-initialized ([#5142](AztecProtocol/aztec-packages#5142)) ([932c1d5](AztecProtocol/aztec-packages@932c1d5)) </details> <details><summary>barretenberg: 0.27.0</summary> ## [0.27.0](AztecProtocol/aztec-packages@barretenberg-v0.26.6...barretenberg-v0.27.0) (2024-03-12) ### Features * **avm:** Equivalence check between Main trace and Mem trace ([#5032](AztecProtocol/aztec-packages#5032)) ([7f216eb](AztecProtocol/aztec-packages@7f216eb)), closes [#4955](AztecProtocol/aztec-packages#4955) * Initial integration avm prover ([#4878](AztecProtocol/aztec-packages#4878)) ([2e2554e](AztecProtocol/aztec-packages@2e2554e)) * Update the core of SMT Circuit class ([#5096](AztecProtocol/aztec-packages#5096)) ([1519d3b](AztecProtocol/aztec-packages@1519d3b)) ### Miscellaneous * **AVM:** Negative unit tests for inter table relations ([#5143](AztecProtocol/aztec-packages#5143)) ([a74dccb](AztecProtocol/aztec-packages@a74dccb)), closes [#5033](AztecProtocol/aztec-packages#5033) * Extract bb binary in bs fast ([#5128](AztecProtocol/aztec-packages#5128)) ([9ca41ef](AztecProtocol/aztec-packages@9ca41ef)) * Join-split example Part 2 ([#5016](AztecProtocol/aztec-packages#5016)) ([0718320](AztecProtocol/aztec-packages@0718320)) * Move alpine containers to ubuntu ([#5026](AztecProtocol/aztec-packages#5026)) ([d483e67](AztecProtocol/aztec-packages@d483e67)), closes [#4708](AztecProtocol/aztec-packages#4708) * Pin foundry ([#5151](AztecProtocol/aztec-packages#5151)) ([69bd7dd](AztecProtocol/aztec-packages@69bd7dd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

fcarreiro force-pushed the fc/db/avm-nested-calls branch from 4102e8d to 1f62d34 Compare March 7, 2024 16:34

fcarreiro requested a review from Maddiaa0 March 7, 2024 16:34

fcarreiro force-pushed the fc/db/avm-nested-calls branch 6 times, most recently from 2647730 to 2a2b881 Compare March 7, 2024 17:14

fcarreiro force-pushed the fc/db/avm-nested-calls branch from 2a2b881 to c49ddbe Compare March 8, 2024 10:14

fcarreiro mentioned this pull request Mar 8, 2024

chore(avm-simulator): enable compressed strings unencrypted log test #5083

Merged

fcarreiro commented Mar 8, 2024

View reviewed changes

noir-projects/aztec-nr/aztec/src/context/avm.nr Show resolved Hide resolved

fcarreiro mentioned this pull request Mar 8, 2024

feat(avm-simulator): external static calls + integration #5089

Merged

fcarreiro changed the base branch from master to fc/avm-small-changes-1 March 8, 2024 14:32

fcarreiro force-pushed the fc/db/avm-nested-calls branch from c49ddbe to b8c2058 Compare March 8, 2024 14:32

This was referenced Mar 8, 2024

feat(avm): fix some Brillig problems #5091

Merged

chore(avm-simulator): formatting and fixes #5092

Merged

fcarreiro force-pushed the fc/db/avm-nested-calls branch from b8c2058 to 028d622 Compare March 8, 2024 14:44

fcarreiro mentioned this pull request Mar 8, 2024

feat(avm-simulator): individual storage access #5095

Closed

fcarreiro force-pushed the fc/avm-small-changes-1 branch from d379a6e to a15b54a Compare March 8, 2024 17:03

fcarreiro force-pushed the fc/db/avm-nested-calls branch from 028d622 to ae8b3f6 Compare March 8, 2024 17:03

Maddiaa0 reviewed Mar 9, 2024

View reviewed changes

avm-transpiler/src/transpile.rs Show resolved Hide resolved

Maddiaa0 reviewed Mar 9, 2024

View reviewed changes

Maddiaa0 approved these changes Mar 9, 2024

View reviewed changes

fcarreiro force-pushed the fc/avm-small-changes-1 branch from a15b54a to 14a4f37 Compare March 11, 2024 10:13

fcarreiro force-pushed the fc/db/avm-nested-calls branch from ae8b3f6 to e9ecf31 Compare March 11, 2024 10:13

fcarreiro force-pushed the fc/avm-small-changes-1 branch from 14a4f37 to 4a5d6c3 Compare March 11, 2024 10:44

Base automatically changed from fc/avm-small-changes-1 to master March 11, 2024 10:50

fcarreiro added 2 commits March 11, 2024 10:51

Based on David's work

4d5a671

address comments

d7b1e1c

fcarreiro force-pushed the fc/db/avm-nested-calls branch from e9ecf31 to d7b1e1c Compare March 11, 2024 10:51

fcarreiro merged commit dde33f4 into master Mar 11, 2024

fcarreiro deleted the fc/db/avm-nested-calls branch March 11, 2024 10:55

AztecBot mentioned this pull request Mar 11, 2024

chore(master): Release 0.27.0 #5100

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm-simulator): external calls + integration#5051

feat(avm-simulator): external calls + integration#5051
fcarreiro merged 2 commits intomasterfrom
fc/db/avm-nested-calls

fcarreiro commented Mar 7, 2024 •

edited

Loading

Uh oh!

fcarreiro commented Mar 7, 2024 •

edited

Loading

Uh oh!

AztecBot commented Mar 7, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

Uh oh!

Uh oh!

Uh oh!

Maddiaa0 Mar 9, 2024

Uh oh!

fcarreiro Mar 11, 2024

Uh oh!

Maddiaa0 Mar 9, 2024

Uh oh!

Maddiaa0 left a comment

Uh oh!

fcarreiro commented Mar 11, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fcarreiro commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fcarreiro commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AztecBot commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

Uh oh!

Uh oh!

Uh oh!

Maddiaa0 Mar 9, 2024

Choose a reason for hiding this comment

Uh oh!

fcarreiro Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

Maddiaa0 Mar 9, 2024

Choose a reason for hiding this comment

Uh oh!

Maddiaa0 left a comment

Choose a reason for hiding this comment

Uh oh!

fcarreiro commented Mar 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fcarreiro commented Mar 7, 2024 •

edited

Loading

fcarreiro commented Mar 7, 2024 •

edited

Loading

AztecBot commented Mar 7, 2024 •

edited

Loading

fcarreiro commented Mar 11, 2024 •

edited

Loading