feat: add hashing to stdlib transcript by lucasxia01 · Pull Request #4161 · AztecProtocol/aztec-packages

lucasxia01 · 2024-01-19T20:14:17Z

Combines native and stdlib transcripts by templating it with a TranscriptParams parameter. This parameter contains the type of field element in the proof (bb::fr for native and field_t for stdlib) and conversion functions for converting from the field element to/from other types.

Adds the stdlib conversion functions, and the convert_challenge function for native and stdlib for turning a challenge into a bn254 scalar or grumpkin scalar.

Resolves AztecProtocol/barretenberg#835.

Please read contributing guidelines and remove this line.

shoudl only be barretenberg::fr for now

updated challenges to be uint256_t for now

…b-hashing

codygunton · 2024-02-02T22:36:32Z

barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp

    {
-        auto poly_degree = static_cast<size_t>(transcript->template receive_from_prover<uint64_t>("IPA:poly_degree"));
-        const Fr generator_challenge = transcript->get_challenge("IPA:generator_challenge");
+        auto poly_degree = static_cast<uint32_t>(transcript->template receive_from_prover<typename Curve::BaseField>(


If it always has to be bb::fr then we should just hard code that.

not sure what to do about this, since I don't hardcoded and just use FF in most cases. I don't feel great about hardcoding bb::fr everywhere.

When I wrote this I thought that something would break if we were to replace bb::fr with another field, but I don't recall now where that thought came from.

We also can't hardcode bb::fr everywhere since we want field_ct in the circuit case, not bb::fr.

codygunton · 2024-02-02T22:42:14Z

barretenberg/cpp/src/barretenberg/stdlib/recursion/honk/transcript/transcript.hpp

         * since it's a pain and we'll be revamping our hashing anyway. For now, simply convert the native hashes to
         * stdlib types without adding any hashing constraints.
         */
+        // we need to call a corresponding stdlib get_next_challenge_buffer in this loop


Is this missing functionality?

No, this file will be deleted actually.

barretenberg/cpp/src/barretenberg/stdlib/primitives/field/field_conversion.cpp

barretenberg/cpp/src/barretenberg/stdlib/primitives/field/field_conversion.hpp

codygunton

Overall nice and clean, if quite verbose. I raise some issues for resolution.

codygunton · 2024-02-06T17:54:33Z

barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp

@@ -183,10 +183,12 @@ template <typename Curve> class IPA {
     */
    static bool verify(const std::shared_ptr<VK>& vk,


Compile errors are good, no need for a github issue here.

codygunton · 2024-02-06T18:01:48Z

barretenberg/cpp/src/barretenberg/ecc/fields/field_conversion.hpp

    return fr_vec;
 }

+bb::fr inline convert_challenge(const bb::fr& f, bb::fr* /*unused*/)


Weird that we have both & and * here--why?

You explained this is to differentiate between two different calls to convert_challenge. Don't love this hack, anyone reading this will be confused, can you clarify, perhaps using the type system?

codygunton · 2024-02-06T18:14:56Z

barretenberg/cpp/src/barretenberg/ecc/fields/field_conversion.cpp

-} // namespace bb::field_conversion
+grumpkin::fr convert_challenge(const bb::fr& f, grumpkin::fr* /*unused*/)
+{
+    const uint64_t NUM_CONVERSION_TWO_LIMB_BITS = 2 * NUM_CONVERSION_LIMB_BITS;


Constant name is confusing. Also if it's determined by bigfield limb size then we should just use an existing constant, right?

There's nothing challenge-specific about this, right? I'd rather name it more directly then like to_grumpkin_scalar

I can't change the name since it should be the same function in all cases. Alternative is to create a constructor that does this and have this call that constructor

codygunton · 2024-02-06T18:28:34Z

barretenberg/cpp/src/barretenberg/proof_system/arithmetization/arithmetization.hpp

+     * @details Does nothing for this class since this IS the conventional Ultra arithmetization
+     * @param new_size
+     */
+    void resize_additional(size_t /*unused*/){};


Can we get rid of this in favor of using the type system?

barretenberg/cpp/src/barretenberg/stdlib/primitives/field/field_conversion.test.cpp

codygunton · 2024-02-06T19:25:40Z

barretenberg/cpp/src/barretenberg/stdlib/primitives/field/field_conversion.cpp

+
+    ASSERT(static_cast<uint256_t>(low_val) + (static_cast<uint256_t>(hi_val) << NUM_CONVERSION_TWO_LIMB_BITS) == value);
+    // checks this decomposition low + hi * 2^64 = value with an add gate
+    fr<Builder>::evaluate_linear_identity(low, hi * shift, -f, fr<Builder>(0));


This function weirds me out, can you 1) leave an issue to audit it and 2) replace the current line with
auto sum = low + hi * shift; assert_equal(f, sum);?

Would we prefer that method? This function is similar to the bigfield constructor which uses evaluate_linear_identity.

codygunton · 2024-02-06T19:32:32Z

barretenberg/cpp/src/barretenberg/stdlib/recursion/honk/verifier/decider_recursive_verifier.cpp


-    const auto instance_size = transcript->template receive_from_prover<uint32_t>("instance_size");
-    const auto public_input_size = transcript->template receive_from_prover<uint32_t>("public_input_size");
+    const auto instance_size = transcript->template receive_from_prover<FF>("instance_size");


I assume that previously this was range constrained? Can you check on this and make sure the range constraints are there if they were before?

Here and elsewhere

These were not range constrained, but why do we want to range constrain them?

barretenberg/cpp/src/barretenberg/transcript/CMakeLists.txt

barretenberg/cpp/src/barretenberg/transcript/transcript.hpp

codygunton · 2024-02-06T20:07:12Z

barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp

    {
-        auto poly_degree = static_cast<size_t>(transcript->template receive_from_prover<uint64_t>("IPA:poly_degree"));
-        const Fr generator_challenge = transcript->get_challenge("IPA:generator_challenge");
+        auto poly_degree = static_cast<uint32_t>(transcript->template receive_from_prover<typename Curve::BaseField>(


When I wrote this I thought that something would break if we were to replace bb::fr with another field, but I don't recall now where that thought came from.

modified convert_to_grumpkin_fr

codygunton

After responding to the comment about evaluate_linear_identity this is ready to go in.

…b-hashing

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.24.0</summary> ## [0.24.0](aztec-packages-v0.23.0...aztec-packages-v0.24.0) (2024-02-13) ### ⚠ BREAKING CHANGES * move noir out of yarn-project ([#4479](#4479)) * note type ids ([#4500](#4500)) ### Features * Add fee payment methods ([#4504](#4504)) ([d107746](d107746)) * Add hashing to stdlib transcript ([#4161](#4161)) ([e78b86f](e78b86f)) * Added cast opcode and cast calldata ([#4423](#4423)) ([e58eda8](e58eda8)) * Added cast opcode and cast calldata (#4423) ([db803bd](db803bd)) * **avm-transpiler:** Implement tags for SET and others ([#4545](#4545)) ([3063bf3](3063bf3)) * **avm:** Implement addressing modes for MOV ([#4490](#4490)) ([ab4eaf0](ab4eaf0)) * **avm:** Introduce small e2e test ([#4470](#4470)) ([7b4c6e7](7b4c6e7)) * Aztec.js API for registering a contract class ([#4469](#4469)) ([d566c74](d566c74)) * **docs:** DIP1 - Extracting how-tos ([#4251](#4251)) ([9d50e24](9d50e24)) * Enable gmock and upgrade gtest to 1.13 ([#4480](#4480)) ([5fc02e7](5fc02e7)) * IVC bench ([#4515](#4515)) ([d8ae42b](d8ae42b)) * Nicer API for instance deployment ([#4493](#4493)) ([99c3fba](99c3fba)) * Note type ids ([#4500](#4500)) ([e1da2fd](e1da2fd)) * Op count timers ([#4471](#4471)) ([26918de](26918de)) * PG + Goblin ([#4399](#4399)) ([295cd55](295cd55)) * Prototype native merkle trees ([#4457](#4457)) ([7d5e056](7d5e056)) * Update rollup circuits and contracts in yp ([#4536](#4536)) ([6e89d53](6e89d53)) ### Bug Fixes * **bb:** Publishing bb for mac intel ([#4523](#4523)) ([4982e3c](4982e3c)) * Broken links in docs [REDO] ([#4540](#4540)) ([ce2a205](ce2a205)) * **build-system:** Image expiring ([#4521](#4521)) ([1501afd](1501afd)) * Convert folding recursive verifier ops to batch mul ([#4517](#4517)) ([3750b26](3750b26)) * Cycle_group validate_is_on_curve bug ([#4494](#4494)) ([fecf3f7](fecf3f7)) * Field divison / journal comparisions ([#4489](#4489)) ([15c06c5](15c06c5)) * Master ([#4547](#4547)) ([490ca26](490ca26)) * Mirror_noir_subrepo.yml ([#4550](#4550)) ([f8d8311](f8d8311)) * Mul with endomorphism ([#4538](#4538)) ([1f4c90d](1f4c90d)) * **noir-mirror:** Don't update .gitrepo on push ([#4555](#4555)) ([686140a](686140a)) * Recreate jest.config.ts for sequencer-client ([#4553](#4553)) ([d172f0b](d172f0b)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([#4530](#4530)) ([ce51d20](ce51d20)) * Use ordered-binary value encoding for multi maps ([#4565](#4565)) ([04ae0d2](04ae0d2)) ### Miscellaneous * Aligning some naming in `BaseOrMergeRollupPublicInputs` ([#4510](#4510)) ([47d66f9](47d66f9)) * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([#4554](#4554)) ([ca4dd60](ca4dd60)) * **avm-simulator:** Reduce boilerplate in AVM memory types ([#4542](#4542)) ([da2f5ed](da2f5ed)) * **avm:** Add/improve tests for AvmContext, tagged memory, etc ([#4484](#4484)) ([2fccdf2](2fccdf2)) * **avm:** Remove field support for comparators and bitwise ops ([#4516](#4516)) ([87a9663](87a9663)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([#4502](#4502)) ([bf4fc6c](bf4fc6c)), closes [#4495](#4495) * Cleanup of `abi.nr` in `aztec-nr` ([#4473](#4473)) ([6d9c73a](6d9c73a)) * Cleanup of `abi.nr` in `aztec-nr` (#4473) [skip ci] ([db803bd](db803bd)) * Create constraints for sha256 compression opcode ([#4503](#4503)) ([64bef49](64bef49)) * Little cpp style improvements ([#4528](#4528)) ([dcc9ba4](dcc9ba4)) * Move noir out of yarn-project ([#4479](#4479)) ([1fe674b](1fe674b)), closes [#4107](#4107) * Pull noir ([#4546](#4546)) ([acf5cf2](acf5cf2)) * Pull noir (#4546) ([db803bd](db803bd)) * Redo noir subrepo force push ([#4514](#4514)) ([7b519a4](7b519a4)) * Remove .oldValue in contract state update request ([#4499](#4499)) ([a796bef](a796bef)) * Removing redundant utilities ([#4532](#4532)) ([79bf445](79bf445)), closes [#3470](#3470) * Rename kernel circuits and disambiguate inputs ([#4535](#4535)) ([ed6d521](ed6d521)) * Replace relative paths to noir-protocol-circuits ([f1accbf](f1accbf)) * Replace relative paths to noir-protocol-circuits ([20ee430](20ee430)) * Replace relative paths to noir-protocol-circuits ([101ab59](101ab59)) * Simulator utils cleanup ([#4507](#4507)) ([1dd0ebf](1dd0ebf)) * Sync to noir-lang/noir ([db803bd](db803bd)) * Testing all values in `PublicGlobalVariables` and `PrivateGlobalVariables` ([#4481](#4481)) ([bc25f9b](bc25f9b)) * Testing historical header in contexts ([#4509](#4509)) ([c00229a](c00229a)) * Updating field conversion code without pointer hack ([#4537](#4537)) ([94f436e](94f436e)) * Uses sha256compression opcode in Noir and implements acvm solver for it ([#4511](#4511)) ([9dc05bc](9dc05bc)) ### Documentation * Describe the new message box model ([#4485](#4485)) ([14cc1dd](14cc1dd)) * Review of docs, so far ([#4505](#4505)) ([140c508](140c508)) * **yellowpaper:** Avm tree-access operations ([#4552](#4552)) ([913f4bd](913f4bd)) * **yellowpaper:** Separate section for AVM state ([#4440](#4440)) ([7881f09](7881f09)) </details> <details><summary>barretenberg.js: 0.24.0</summary> ## [0.24.0](barretenberg.js-v0.23.0...barretenberg.js-v0.24.0) (2024-02-13) ### Features * Prototype native merkle trees ([#4457](#4457)) ([7d5e056](7d5e056)) </details> <details><summary>barretenberg: 0.24.0</summary> ## [0.24.0](barretenberg-v0.23.0...barretenberg-v0.24.0) (2024-02-13) ### Features * Add hashing to stdlib transcript ([#4161](#4161)) ([e78b86f](e78b86f)) * Added cast opcode and cast calldata ([#4423](#4423)) ([e58eda8](e58eda8)) * Enable gmock and upgrade gtest to 1.13 ([#4480](#4480)) ([5fc02e7](5fc02e7)) * IVC bench ([#4515](#4515)) ([d8ae42b](d8ae42b)) * Op count timers ([#4471](#4471)) ([26918de](26918de)) * PG + Goblin ([#4399](#4399)) ([295cd55](295cd55)) * Prototype native merkle trees ([#4457](#4457)) ([7d5e056](7d5e056)) ### Bug Fixes * Convert folding recursive verifier ops to batch mul ([#4517](#4517)) ([3750b26](3750b26)) * Cycle_group validate_is_on_curve bug ([#4494](#4494)) ([fecf3f7](fecf3f7)) * Mul with endomorphism ([#4538](#4538)) ([1f4c90d](1f4c90d)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([#4530](#4530)) ([ce51d20](ce51d20)) ### Miscellaneous * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([#4554](#4554)) ([ca4dd60](ca4dd60)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([#4502](#4502)) ([bf4fc6c](bf4fc6c)), closes [#4495](#4495) * Create constraints for sha256 compression opcode ([#4503](#4503)) ([64bef49](64bef49)) * Little cpp style improvements ([#4528](#4528)) ([dcc9ba4](dcc9ba4)) * Updating field conversion code without pointer hack ([#4537](#4537)) ([94f436e](94f436e)) ### Documentation * **yellowpaper:** Avm tree-access operations ([#4552](#4552)) ([913f4bd](913f4bd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@aztec-packages-v0.23.0...aztec-packages-v0.24.0) (2024-02-13) ### ⚠ BREAKING CHANGES * move noir out of yarn-project ([#4479](AztecProtocol/aztec-packages#4479)) * note type ids ([#4500](AztecProtocol/aztec-packages#4500)) ### Features * Add fee payment methods ([#4504](AztecProtocol/aztec-packages#4504)) ([d107746](AztecProtocol/aztec-packages@d107746)) * Add hashing to stdlib transcript ([#4161](AztecProtocol/aztec-packages#4161)) ([e78b86f](AztecProtocol/aztec-packages@e78b86f)) * Added cast opcode and cast calldata ([#4423](AztecProtocol/aztec-packages#4423)) ([e58eda8](AztecProtocol/aztec-packages@e58eda8)) * Added cast opcode and cast calldata (AztecProtocol/aztec-packages#4423) ([db803bd](AztecProtocol/aztec-packages@db803bd)) * **avm-transpiler:** Implement tags for SET and others ([#4545](AztecProtocol/aztec-packages#4545)) ([3063bf3](AztecProtocol/aztec-packages@3063bf3)) * **avm:** Implement addressing modes for MOV ([#4490](AztecProtocol/aztec-packages#4490)) ([ab4eaf0](AztecProtocol/aztec-packages@ab4eaf0)) * **avm:** Introduce small e2e test ([#4470](AztecProtocol/aztec-packages#4470)) ([7b4c6e7](AztecProtocol/aztec-packages@7b4c6e7)) * Aztec.js API for registering a contract class ([#4469](AztecProtocol/aztec-packages#4469)) ([d566c74](AztecProtocol/aztec-packages@d566c74)) * **docs:** DIP1 - Extracting how-tos ([#4251](AztecProtocol/aztec-packages#4251)) ([9d50e24](AztecProtocol/aztec-packages@9d50e24)) * Enable gmock and upgrade gtest to 1.13 ([#4480](AztecProtocol/aztec-packages#4480)) ([5fc02e7](AztecProtocol/aztec-packages@5fc02e7)) * IVC bench ([#4515](AztecProtocol/aztec-packages#4515)) ([d8ae42b](AztecProtocol/aztec-packages@d8ae42b)) * Nicer API for instance deployment ([#4493](AztecProtocol/aztec-packages#4493)) ([99c3fba](AztecProtocol/aztec-packages@99c3fba)) * Note type ids ([#4500](AztecProtocol/aztec-packages#4500)) ([e1da2fd](AztecProtocol/aztec-packages@e1da2fd)) * Op count timers ([#4471](AztecProtocol/aztec-packages#4471)) ([26918de](AztecProtocol/aztec-packages@26918de)) * PG + Goblin ([#4399](AztecProtocol/aztec-packages#4399)) ([295cd55](AztecProtocol/aztec-packages@295cd55)) * Prototype native merkle trees ([#4457](AztecProtocol/aztec-packages#4457)) ([7d5e056](AztecProtocol/aztec-packages@7d5e056)) * Update rollup circuits and contracts in yp ([#4536](AztecProtocol/aztec-packages#4536)) ([6e89d53](AztecProtocol/aztec-packages@6e89d53)) ### Bug Fixes * **bb:** Publishing bb for mac intel ([#4523](AztecProtocol/aztec-packages#4523)) ([4982e3c](AztecProtocol/aztec-packages@4982e3c)) * Broken links in docs [REDO] ([#4540](AztecProtocol/aztec-packages#4540)) ([ce2a205](AztecProtocol/aztec-packages@ce2a205)) * **build-system:** Image expiring ([#4521](AztecProtocol/aztec-packages#4521)) ([1501afd](AztecProtocol/aztec-packages@1501afd)) * Convert folding recursive verifier ops to batch mul ([#4517](AztecProtocol/aztec-packages#4517)) ([3750b26](AztecProtocol/aztec-packages@3750b26)) * Cycle_group validate_is_on_curve bug ([#4494](AztecProtocol/aztec-packages#4494)) ([fecf3f7](AztecProtocol/aztec-packages@fecf3f7)) * Field divison / journal comparisions ([#4489](AztecProtocol/aztec-packages#4489)) ([15c06c5](AztecProtocol/aztec-packages@15c06c5)) * Master ([#4547](AztecProtocol/aztec-packages#4547)) ([490ca26](AztecProtocol/aztec-packages@490ca26)) * Mirror_noir_subrepo.yml ([#4550](AztecProtocol/aztec-packages#4550)) ([f8d8311](AztecProtocol/aztec-packages@f8d8311)) * Mul with endomorphism ([#4538](AztecProtocol/aztec-packages#4538)) ([1f4c90d](AztecProtocol/aztec-packages@1f4c90d)) * **noir-mirror:** Don't update .gitrepo on push ([#4555](AztecProtocol/aztec-packages#4555)) ([686140a](AztecProtocol/aztec-packages@686140a)) * Recreate jest.config.ts for sequencer-client ([#4553](AztecProtocol/aztec-packages#4553)) ([d172f0b](AztecProtocol/aztec-packages@d172f0b)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([#4530](AztecProtocol/aztec-packages#4530)) ([ce51d20](AztecProtocol/aztec-packages@ce51d20)) * Use ordered-binary value encoding for multi maps ([#4565](AztecProtocol/aztec-packages#4565)) ([04ae0d2](AztecProtocol/aztec-packages@04ae0d2)) ### Miscellaneous * Aligning some naming in `BaseOrMergeRollupPublicInputs` ([#4510](AztecProtocol/aztec-packages#4510)) ([47d66f9](AztecProtocol/aztec-packages@47d66f9)) * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([#4554](AztecProtocol/aztec-packages#4554)) ([ca4dd60](AztecProtocol/aztec-packages@ca4dd60)) * **avm-simulator:** Reduce boilerplate in AVM memory types ([#4542](AztecProtocol/aztec-packages#4542)) ([da2f5ed](AztecProtocol/aztec-packages@da2f5ed)) * **avm:** Add/improve tests for AvmContext, tagged memory, etc ([#4484](AztecProtocol/aztec-packages#4484)) ([2fccdf2](AztecProtocol/aztec-packages@2fccdf2)) * **avm:** Remove field support for comparators and bitwise ops ([#4516](AztecProtocol/aztec-packages#4516)) ([87a9663](AztecProtocol/aztec-packages@87a9663)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([#4502](AztecProtocol/aztec-packages#4502)) ([bf4fc6c](AztecProtocol/aztec-packages@bf4fc6c)), closes [#4495](AztecProtocol/aztec-packages#4495) * Cleanup of `abi.nr` in `aztec-nr` ([#4473](AztecProtocol/aztec-packages#4473)) ([6d9c73a](AztecProtocol/aztec-packages@6d9c73a)) * Cleanup of `abi.nr` in `aztec-nr` (AztecProtocol/aztec-packages#4473) [skip ci] ([db803bd](AztecProtocol/aztec-packages@db803bd)) * Create constraints for sha256 compression opcode ([#4503](AztecProtocol/aztec-packages#4503)) ([64bef49](AztecProtocol/aztec-packages@64bef49)) * Little cpp style improvements ([#4528](AztecProtocol/aztec-packages#4528)) ([dcc9ba4](AztecProtocol/aztec-packages@dcc9ba4)) * Move noir out of yarn-project ([#4479](AztecProtocol/aztec-packages#4479)) ([1fe674b](AztecProtocol/aztec-packages@1fe674b)), closes [#4107](AztecProtocol/aztec-packages#4107) * Pull noir ([#4546](AztecProtocol/aztec-packages#4546)) ([acf5cf2](AztecProtocol/aztec-packages@acf5cf2)) * Pull noir (AztecProtocol/aztec-packages#4546) ([db803bd](AztecProtocol/aztec-packages@db803bd)) * Redo noir subrepo force push ([#4514](AztecProtocol/aztec-packages#4514)) ([7b519a4](AztecProtocol/aztec-packages@7b519a4)) * Remove .oldValue in contract state update request ([#4499](AztecProtocol/aztec-packages#4499)) ([a796bef](AztecProtocol/aztec-packages@a796bef)) * Removing redundant utilities ([#4532](AztecProtocol/aztec-packages#4532)) ([79bf445](AztecProtocol/aztec-packages@79bf445)), closes [#3470](AztecProtocol/aztec-packages#3470) * Rename kernel circuits and disambiguate inputs ([#4535](AztecProtocol/aztec-packages#4535)) ([ed6d521](AztecProtocol/aztec-packages@ed6d521)) * Replace relative paths to noir-protocol-circuits ([f1accbf](AztecProtocol/aztec-packages@f1accbf)) * Replace relative paths to noir-protocol-circuits ([20ee430](AztecProtocol/aztec-packages@20ee430)) * Replace relative paths to noir-protocol-circuits ([101ab59](AztecProtocol/aztec-packages@101ab59)) * Simulator utils cleanup ([#4507](AztecProtocol/aztec-packages#4507)) ([1dd0ebf](AztecProtocol/aztec-packages@1dd0ebf)) * Sync to noir-lang/noir ([db803bd](AztecProtocol/aztec-packages@db803bd)) * Testing all values in `PublicGlobalVariables` and `PrivateGlobalVariables` ([#4481](AztecProtocol/aztec-packages#4481)) ([bc25f9b](AztecProtocol/aztec-packages@bc25f9b)) * Testing historical header in contexts ([#4509](AztecProtocol/aztec-packages#4509)) ([c00229a](AztecProtocol/aztec-packages@c00229a)) * Updating field conversion code without pointer hack ([#4537](AztecProtocol/aztec-packages#4537)) ([94f436e](AztecProtocol/aztec-packages@94f436e)) * Uses sha256compression opcode in Noir and implements acvm solver for it ([#4511](AztecProtocol/aztec-packages#4511)) ([9dc05bc](AztecProtocol/aztec-packages@9dc05bc)) ### Documentation * Describe the new message box model ([#4485](AztecProtocol/aztec-packages#4485)) ([14cc1dd](AztecProtocol/aztec-packages@14cc1dd)) * Review of docs, so far ([#4505](AztecProtocol/aztec-packages#4505)) ([140c508](AztecProtocol/aztec-packages@140c508)) * **yellowpaper:** Avm tree-access operations ([#4552](AztecProtocol/aztec-packages#4552)) ([913f4bd](AztecProtocol/aztec-packages@913f4bd)) * **yellowpaper:** Separate section for AVM state ([#4440](AztecProtocol/aztec-packages#4440)) ([7881f09](AztecProtocol/aztec-packages@7881f09)) </details> <details><summary>barretenberg.js: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@barretenberg.js-v0.23.0...barretenberg.js-v0.24.0) (2024-02-13) ### Features * Prototype native merkle trees ([#4457](AztecProtocol/aztec-packages#4457)) ([7d5e056](AztecProtocol/aztec-packages@7d5e056)) </details> <details><summary>barretenberg: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@barretenberg-v0.23.0...barretenberg-v0.24.0) (2024-02-13) ### Features * Add hashing to stdlib transcript ([#4161](AztecProtocol/aztec-packages#4161)) ([e78b86f](AztecProtocol/aztec-packages@e78b86f)) * Added cast opcode and cast calldata ([#4423](AztecProtocol/aztec-packages#4423)) ([e58eda8](AztecProtocol/aztec-packages@e58eda8)) * Enable gmock and upgrade gtest to 1.13 ([#4480](AztecProtocol/aztec-packages#4480)) ([5fc02e7](AztecProtocol/aztec-packages@5fc02e7)) * IVC bench ([#4515](AztecProtocol/aztec-packages#4515)) ([d8ae42b](AztecProtocol/aztec-packages@d8ae42b)) * Op count timers ([#4471](AztecProtocol/aztec-packages#4471)) ([26918de](AztecProtocol/aztec-packages@26918de)) * PG + Goblin ([#4399](AztecProtocol/aztec-packages#4399)) ([295cd55](AztecProtocol/aztec-packages@295cd55)) * Prototype native merkle trees ([#4457](AztecProtocol/aztec-packages#4457)) ([7d5e056](AztecProtocol/aztec-packages@7d5e056)) ### Bug Fixes * Convert folding recursive verifier ops to batch mul ([#4517](AztecProtocol/aztec-packages#4517)) ([3750b26](AztecProtocol/aztec-packages@3750b26)) * Cycle_group validate_is_on_curve bug ([#4494](AztecProtocol/aztec-packages#4494)) ([fecf3f7](AztecProtocol/aztec-packages@fecf3f7)) * Mul with endomorphism ([#4538](AztecProtocol/aztec-packages#4538)) ([1f4c90d](AztecProtocol/aztec-packages@1f4c90d)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([#4530](AztecProtocol/aztec-packages#4530)) ([ce51d20](AztecProtocol/aztec-packages@ce51d20)) ### Miscellaneous * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([#4554](AztecProtocol/aztec-packages#4554)) ([ca4dd60](AztecProtocol/aztec-packages@ca4dd60)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([#4502](AztecProtocol/aztec-packages#4502)) ([bf4fc6c](AztecProtocol/aztec-packages@bf4fc6c)), closes [#4495](AztecProtocol/aztec-packages#4495) * Create constraints for sha256 compression opcode ([#4503](AztecProtocol/aztec-packages#4503)) ([64bef49](AztecProtocol/aztec-packages@64bef49)) * Little cpp style improvements ([#4528](AztecProtocol/aztec-packages#4528)) ([dcc9ba4](AztecProtocol/aztec-packages@dcc9ba4)) * Updating field conversion code without pointer hack ([#4537](AztecProtocol/aztec-packages#4537)) ([94f436e](AztecProtocol/aztec-packages@94f436e)) ### Documentation * **yellowpaper:** Avm tree-access operations ([#4552](AztecProtocol/aztec-packages#4552)) ([913f4bd](AztecProtocol/aztec-packages@913f4bd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Combines native and stdlib transcripts by templating it with a TranscriptParams parameter. This parameter contains the type of field element in the proof (bb::fr for native and field_t<Builder> for stdlib) and conversion functions for converting from the field element to/from other types. Adds the stdlib conversion functions, and the convert_challenge function for native and stdlib for turning a challenge into a bn254 scalar or grumpkin scalar. Resolves AztecProtocol/barretenberg#835. --------- Co-authored-by: codygunton <codygunton@gmail.com>

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@aztec-packages-v0.23.0...aztec-packages-v0.24.0) (2024-02-13) ### ⚠ BREAKING CHANGES * move noir out of yarn-project ([AztecProtocol#4479](AztecProtocol#4479)) * note type ids ([AztecProtocol#4500](AztecProtocol#4500)) ### Features * Add fee payment methods ([AztecProtocol#4504](AztecProtocol#4504)) ([d107746](AztecProtocol@d107746)) * Add hashing to stdlib transcript ([AztecProtocol#4161](AztecProtocol#4161)) ([e78b86f](AztecProtocol@e78b86f)) * Added cast opcode and cast calldata ([AztecProtocol#4423](AztecProtocol#4423)) ([e58eda8](AztecProtocol@e58eda8)) * Added cast opcode and cast calldata (AztecProtocol#4423) ([db803bd](AztecProtocol@db803bd)) * **avm-transpiler:** Implement tags for SET and others ([AztecProtocol#4545](AztecProtocol#4545)) ([3063bf3](AztecProtocol@3063bf3)) * **avm:** Implement addressing modes for MOV ([AztecProtocol#4490](AztecProtocol#4490)) ([ab4eaf0](AztecProtocol@ab4eaf0)) * **avm:** Introduce small e2e test ([AztecProtocol#4470](AztecProtocol#4470)) ([7b4c6e7](AztecProtocol@7b4c6e7)) * Aztec.js API for registering a contract class ([AztecProtocol#4469](AztecProtocol#4469)) ([d566c74](AztecProtocol@d566c74)) * **docs:** DIP1 - Extracting how-tos ([AztecProtocol#4251](AztecProtocol#4251)) ([9d50e24](AztecProtocol@9d50e24)) * Enable gmock and upgrade gtest to 1.13 ([AztecProtocol#4480](AztecProtocol#4480)) ([5fc02e7](AztecProtocol@5fc02e7)) * IVC bench ([AztecProtocol#4515](AztecProtocol#4515)) ([d8ae42b](AztecProtocol@d8ae42b)) * Nicer API for instance deployment ([AztecProtocol#4493](AztecProtocol#4493)) ([99c3fba](AztecProtocol@99c3fba)) * Note type ids ([AztecProtocol#4500](AztecProtocol#4500)) ([e1da2fd](AztecProtocol@e1da2fd)) * Op count timers ([AztecProtocol#4471](AztecProtocol#4471)) ([26918de](AztecProtocol@26918de)) * PG + Goblin ([AztecProtocol#4399](AztecProtocol#4399)) ([295cd55](AztecProtocol@295cd55)) * Prototype native merkle trees ([AztecProtocol#4457](AztecProtocol#4457)) ([7d5e056](AztecProtocol@7d5e056)) * Update rollup circuits and contracts in yp ([AztecProtocol#4536](AztecProtocol#4536)) ([6e89d53](AztecProtocol@6e89d53)) ### Bug Fixes * **bb:** Publishing bb for mac intel ([AztecProtocol#4523](AztecProtocol#4523)) ([4982e3c](AztecProtocol@4982e3c)) * Broken links in docs [REDO] ([AztecProtocol#4540](AztecProtocol#4540)) ([ce2a205](AztecProtocol@ce2a205)) * **build-system:** Image expiring ([AztecProtocol#4521](AztecProtocol#4521)) ([1501afd](AztecProtocol@1501afd)) * Convert folding recursive verifier ops to batch mul ([AztecProtocol#4517](AztecProtocol#4517)) ([3750b26](AztecProtocol@3750b26)) * Cycle_group validate_is_on_curve bug ([AztecProtocol#4494](AztecProtocol#4494)) ([fecf3f7](AztecProtocol@fecf3f7)) * Field divison / journal comparisions ([AztecProtocol#4489](AztecProtocol#4489)) ([15c06c5](AztecProtocol@15c06c5)) * Master ([AztecProtocol#4547](AztecProtocol#4547)) ([490ca26](AztecProtocol@490ca26)) * Mirror_noir_subrepo.yml ([AztecProtocol#4550](AztecProtocol#4550)) ([f8d8311](AztecProtocol@f8d8311)) * Mul with endomorphism ([AztecProtocol#4538](AztecProtocol#4538)) ([1f4c90d](AztecProtocol@1f4c90d)) * **noir-mirror:** Don't update .gitrepo on push ([AztecProtocol#4555](AztecProtocol#4555)) ([686140a](AztecProtocol@686140a)) * Recreate jest.config.ts for sequencer-client ([AztecProtocol#4553](AztecProtocol#4553)) ([d172f0b](AztecProtocol@d172f0b)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([AztecProtocol#4530](AztecProtocol#4530)) ([ce51d20](AztecProtocol@ce51d20)) * Use ordered-binary value encoding for multi maps ([AztecProtocol#4565](AztecProtocol#4565)) ([04ae0d2](AztecProtocol@04ae0d2)) ### Miscellaneous * Aligning some naming in `BaseOrMergeRollupPublicInputs` ([AztecProtocol#4510](AztecProtocol#4510)) ([47d66f9](AztecProtocol@47d66f9)) * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([AztecProtocol#4554](AztecProtocol#4554)) ([ca4dd60](AztecProtocol@ca4dd60)) * **avm-simulator:** Reduce boilerplate in AVM memory types ([AztecProtocol#4542](AztecProtocol#4542)) ([da2f5ed](AztecProtocol@da2f5ed)) * **avm:** Add/improve tests for AvmContext, tagged memory, etc ([AztecProtocol#4484](AztecProtocol#4484)) ([2fccdf2](AztecProtocol@2fccdf2)) * **avm:** Remove field support for comparators and bitwise ops ([AztecProtocol#4516](AztecProtocol#4516)) ([87a9663](AztecProtocol@87a9663)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([AztecProtocol#4502](AztecProtocol#4502)) ([bf4fc6c](AztecProtocol@bf4fc6c)), closes [AztecProtocol#4495](AztecProtocol#4495) * Cleanup of `abi.nr` in `aztec-nr` ([AztecProtocol#4473](AztecProtocol#4473)) ([6d9c73a](AztecProtocol@6d9c73a)) * Cleanup of `abi.nr` in `aztec-nr` (AztecProtocol#4473) [skip ci] ([db803bd](AztecProtocol@db803bd)) * Create constraints for sha256 compression opcode ([AztecProtocol#4503](AztecProtocol#4503)) ([64bef49](AztecProtocol@64bef49)) * Little cpp style improvements ([AztecProtocol#4528](AztecProtocol#4528)) ([dcc9ba4](AztecProtocol@dcc9ba4)) * Move noir out of yarn-project ([AztecProtocol#4479](AztecProtocol#4479)) ([1fe674b](AztecProtocol@1fe674b)), closes [AztecProtocol#4107](AztecProtocol#4107) * Pull noir ([AztecProtocol#4546](AztecProtocol#4546)) ([acf5cf2](AztecProtocol@acf5cf2)) * Pull noir (AztecProtocol#4546) ([db803bd](AztecProtocol@db803bd)) * Redo noir subrepo force push ([AztecProtocol#4514](AztecProtocol#4514)) ([7b519a4](AztecProtocol@7b519a4)) * Remove .oldValue in contract state update request ([AztecProtocol#4499](AztecProtocol#4499)) ([a796bef](AztecProtocol@a796bef)) * Removing redundant utilities ([AztecProtocol#4532](AztecProtocol#4532)) ([79bf445](AztecProtocol@79bf445)), closes [AztecProtocol#3470](AztecProtocol#3470) * Rename kernel circuits and disambiguate inputs ([AztecProtocol#4535](AztecProtocol#4535)) ([ed6d521](AztecProtocol@ed6d521)) * Replace relative paths to noir-protocol-circuits ([f1accbf](AztecProtocol@f1accbf)) * Replace relative paths to noir-protocol-circuits ([20ee430](AztecProtocol@20ee430)) * Replace relative paths to noir-protocol-circuits ([101ab59](AztecProtocol@101ab59)) * Simulator utils cleanup ([AztecProtocol#4507](AztecProtocol#4507)) ([1dd0ebf](AztecProtocol@1dd0ebf)) * Sync to noir-lang/noir ([db803bd](AztecProtocol@db803bd)) * Testing all values in `PublicGlobalVariables` and `PrivateGlobalVariables` ([AztecProtocol#4481](AztecProtocol#4481)) ([bc25f9b](AztecProtocol@bc25f9b)) * Testing historical header in contexts ([AztecProtocol#4509](AztecProtocol#4509)) ([c00229a](AztecProtocol@c00229a)) * Updating field conversion code without pointer hack ([AztecProtocol#4537](AztecProtocol#4537)) ([94f436e](AztecProtocol@94f436e)) * Uses sha256compression opcode in Noir and implements acvm solver for it ([AztecProtocol#4511](AztecProtocol#4511)) ([9dc05bc](AztecProtocol@9dc05bc)) ### Documentation * Describe the new message box model ([AztecProtocol#4485](AztecProtocol#4485)) ([14cc1dd](AztecProtocol@14cc1dd)) * Review of docs, so far ([AztecProtocol#4505](AztecProtocol#4505)) ([140c508](AztecProtocol@140c508)) * **yellowpaper:** Avm tree-access operations ([AztecProtocol#4552](AztecProtocol#4552)) ([913f4bd](AztecProtocol@913f4bd)) * **yellowpaper:** Separate section for AVM state ([AztecProtocol#4440](AztecProtocol#4440)) ([7881f09](AztecProtocol@7881f09)) </details> <details><summary>barretenberg.js: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@barretenberg.js-v0.23.0...barretenberg.js-v0.24.0) (2024-02-13) ### Features * Prototype native merkle trees ([AztecProtocol#4457](AztecProtocol#4457)) ([7d5e056](AztecProtocol@7d5e056)) </details> <details><summary>barretenberg: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@barretenberg-v0.23.0...barretenberg-v0.24.0) (2024-02-13) ### Features * Add hashing to stdlib transcript ([AztecProtocol#4161](AztecProtocol#4161)) ([e78b86f](AztecProtocol@e78b86f)) * Added cast opcode and cast calldata ([AztecProtocol#4423](AztecProtocol#4423)) ([e58eda8](AztecProtocol@e58eda8)) * Enable gmock and upgrade gtest to 1.13 ([AztecProtocol#4480](AztecProtocol#4480)) ([5fc02e7](AztecProtocol@5fc02e7)) * IVC bench ([AztecProtocol#4515](AztecProtocol#4515)) ([d8ae42b](AztecProtocol@d8ae42b)) * Op count timers ([AztecProtocol#4471](AztecProtocol#4471)) ([26918de](AztecProtocol@26918de)) * PG + Goblin ([AztecProtocol#4399](AztecProtocol#4399)) ([295cd55](AztecProtocol@295cd55)) * Prototype native merkle trees ([AztecProtocol#4457](AztecProtocol#4457)) ([7d5e056](AztecProtocol@7d5e056)) ### Bug Fixes * Convert folding recursive verifier ops to batch mul ([AztecProtocol#4517](AztecProtocol#4517)) ([3750b26](AztecProtocol@3750b26)) * Cycle_group validate_is_on_curve bug ([AztecProtocol#4494](AztecProtocol#4494)) ([fecf3f7](AztecProtocol@fecf3f7)) * Mul with endomorphism ([AztecProtocol#4538](AztecProtocol#4538)) ([1f4c90d](AztecProtocol@1f4c90d)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([AztecProtocol#4530](AztecProtocol#4530)) ([ce51d20](AztecProtocol@ce51d20)) ### Miscellaneous * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([AztecProtocol#4554](AztecProtocol#4554)) ([ca4dd60](AztecProtocol@ca4dd60)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([AztecProtocol#4502](AztecProtocol#4502)) ([bf4fc6c](AztecProtocol@bf4fc6c)), closes [AztecProtocol#4495](AztecProtocol#4495) * Create constraints for sha256 compression opcode ([AztecProtocol#4503](AztecProtocol#4503)) ([64bef49](AztecProtocol@64bef49)) * Little cpp style improvements ([AztecProtocol#4528](AztecProtocol#4528)) ([dcc9ba4](AztecProtocol@dcc9ba4)) * Updating field conversion code without pointer hack ([AztecProtocol#4537](AztecProtocol#4537)) ([94f436e](AztecProtocol@94f436e)) ### Documentation * **yellowpaper:** Avm tree-access operations ([AztecProtocol#4552](AztecProtocol#4552)) ([913f4bd](AztecProtocol@913f4bd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

lucasxia01 added 27 commits January 13, 2024 01:22

added poseidon2 to native transcript

29a0d28

wip

61c9eca

removed grumpkin poseidon2 params

a8204fb

removed transcript template param,

05085c5

shoudl only be barretenberg::fr for now

removing poseidon2 grumpkin

99bd01d

updated challenges to be uint256_t for now

removed template param from honk::proof

029350c

linker error be gone among other merge errors

a045b6d

conversions

86065bc

updated calc_num_frs() with all transcript types

d50ac92

completed convert_to_bn254_frs for various transcript types

5f46e2d

convert_from_bn254_frs initial impl updated

d157087

fixing bugs (wip)

f769528

hacky solution to templating to get things to compile

e8702c7

checking if CI tests still fail

86eae85

fixed bugs in conversions

4a04326

added (partial) unit tests

2d16e5d

updated structuring and tests

2c6406d

temporary "fix" to ci gcc compile error

c0c715c

cleaning up field conversion calc_num_frs style

dd3366c

undo challenge fix

b37bed8

pushing linker error

09f7ea2

Merge branch 'master' into lx/transcript-native-field-refactor

7346629

changed to bb::

1484030

inline + comments + cleanup

97c2f88

completed tests, small updates

e2f7526

Merge branch 'master' into lx/transcript-native-field-refactor

f67148d

initial stdlib conversions

0a8b2fc

lucasxia01 changed the title ~~initial stdlib conversions~~ feat: add hashing to stdlib transcript Jan 19, 2024

lucasxia01 marked this pull request as draft January 19, 2024 20:27

lucasxia01 self-assigned this Jan 19, 2024

lucasxia01 added 2 commits January 31, 2024 19:46

test fix

22b3f56

Merge remote-tracking branch 'origin/master' into lx/transcript-stdli…

7fb693c

…b-hashing

codygunton self-requested a review February 2, 2024 16:49

codygunton mentioned this pull request Feb 2, 2024

feat: adding poseidon2 hashing to native and recursive transcript #3652

Closed

4 tasks

codygunton added 4 commits February 2, 2024 18:10

Merge remote-tracking branch 'origin/master' into lx/transcript-stdli…

f376c16

…b-hashing

Fix GCC

1586230

Merge remote-tracking branch 'origin/master' into lx/transcript-stdli…

81279e9

…b-hashing

Revert scratch

33940e4

codygunton reviewed Feb 2, 2024

View reviewed changes

lucasxia01 added 2 commits February 5, 2024 22:54

updated stdlib grumpkin element conversion and refactored

8d89cc1

delete the existing stdlib transcript

be52ead

codygunton requested changes Feb 6, 2024

View reviewed changes

lucasxia01 added 4 commits February 7, 2024 20:22

addressing minor comments

38d6909

fixed dependencies to remove cycle

123abba

removed no op functions in arithmetization

cdbb894

added tests for converting challenges,

a8765e4

modified convert_to_grumpkin_fr

codygunton approved these changes Feb 8, 2024

View reviewed changes

lucasxia01 added 5 commits February 8, 2024 20:30

changed evaluate_linear_identity to assert_equal

69d9bde

Merge branch 'master' into lx/transcript-stdlib-hashing

4b007e1

Merge remote-tracking branch 'origin/master' into lx/transcript-stdli…

c3f3d94

…b-hashing

added TODO comments

a7e6559

Merge branch 'master' into lx/transcript-stdlib-hashing

5963b98

lucasxia01 merged commit e78b86f into master Feb 8, 2024

lucasxia01 deleted the lx/transcript-stdlib-hashing branch February 8, 2024 21:45

AztecBot mentioned this pull request Feb 8, 2024

chore(master): Release 0.24.0 #4491

Merged

lucasxia01 linked an issue Feb 9, 2024 that may be closed by this pull request

Add constraints for hashing in Honk stdlib Transcript #1351

Closed

		@@ -183,10 +183,12 @@ template <typename Curve> class IPA {
		*/
		static bool verify(const std::shared_ptr<VK>& vk,

Conversation

lucasxia01 commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codygunton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codygunton left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lucasxia01 commented Jan 19, 2024 •

edited

Loading