Skip to content

fix(cli): Unbox command should run as release #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 3 commits into from
Jan 12, 2024
Merged

fix(cli): Unbox command should run as release #3974

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ecbaab
fix(cli): Unbox command should run as release
spalladino Jan 12, 2024
0f4ca91
Move COMMIT_TAG env var to yarn project prod image
spalladino Jan 12, 2024
50eb396
Do not remove previous commit_tag
spalladino Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion yarn-project/Dockerfile.prod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ FROM node:18.19.0 AS builder
RUN apt update && apt install -y jq && rm -rf /var/lib/apt/lists/* && apt-get clean
COPY --from=yarn-project /usr/src /usr/src
WORKDIR /usr/src/yarn-project
ARG COMMIT_TAG=""
# TODO: Use release-please to update package.json directly, and remove this!
RUN ./scripts/version_packages.sh
# Productionify. See comment in yarn-project-base/Dockerfile.
Expand All @@ -28,6 +27,8 @@ RUN rm -rf /usr/src/noir/target
# We could also use distroless, to get us about 20mb off, but meh. It's actually useful to shell into containers.
#FROM gcr.io/distroless/nodejs18-debian12
FROM ubuntu:lunar
ARG COMMIT_TAG=""
ENV COMMIT_TAG=$COMMIT_TAG
# RUN apt update && apt install -y nodejs && rm -rf /var/lib/apt/lists/* && apt-get clean
RUN apt update && apt install -y curl && rm -rf /var/lib/apt/lists/* && apt-get clean
ENV NODE_VERSION=18.19.0
Expand Down