Skip to content

fix: CRS not needed for gate_count. Grumpkin not needed for non-goblin. #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlielye merged 2 commits into from
Jan 8, 2024
Merged

fix: CRS not needed for gate_count. Grumpkin not needed for non-goblin. #3872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aebc065
CRS not needed for gate_count. Grumpkin not needed for non-goblin.
charlielye Jan 8, 2024
f2390f3
Merge branch 'master' into cl/gate_count_no_crs
sirasistant Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions barretenberg/cpp/src/barretenberg/bb/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ acir_proofs::AcirComposer init(acir_format::acir_format& constraint_system)
auto bn254_g2_data = get_bn254_g2_data(CRS_PATH);
srs::init_crs_factory(bn254_g1_data, bn254_g2_data);

// Must +1!
auto grumpkin_g1_data = get_grumpkin_g1_data(CRS_PATH, subgroup_size + 1);
srs::init_grumpkin_crs_factory(grumpkin_g1_data);

return acir_composer;
}

Expand Down Expand Up @@ -203,7 +199,8 @@ void prove(const std::string& bytecodePath,
void gateCount(const std::string& bytecodePath)
{
auto constraint_system = get_constraint_system(bytecodePath);
auto acir_composer = init(constraint_system);
acir_proofs::AcirComposer acir_composer(0, verbose);
acir_composer.create_circuit(constraint_system);
auto gate_count = acir_composer.get_total_circuit_size();

writeUint64AsRawBytesToStdout(static_cast<uint64_t>(gate_count));
Expand Down