Skip to content

feat: Doxygen init#3859

Closed
codygunton wants to merge 5 commits intomasterfrom
cg/doxygen-eg
Closed

feat: Doxygen init#3859
codygunton wants to merge 5 commits intomasterfrom
cg/doxygen-eg

Conversation

@codygunton
Copy link
Contributor

@codygunton codygunton commented Jan 5, 2024

Cherry picks from AztecProtocol/barretenberg#132 to choose some Doxygen settings and add documentation and examples to illustrate Doxygen's functionality.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@codygunton codygunton changed the title Doxygen startup feat:Doxygen init Jan 5, 2024
@codygunton codygunton self-assigned this Jan 5, 2024
@codygunton codygunton changed the title feat:Doxygen init feat: Doxygen init Jan 8, 2024
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 8, 2024

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 19d2bbea and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 54,212 214,436 855,332
l1_rollup_calldata_gas 259,844 1,019,672 4,059,992
l1_rollup_execution_gas 354,030 1,139,120 4,281,393
l2_block_processing_time_in_ms 1,254 (-1%) 4,724 (-1%) 18,751 (-1%)
note_successful_decrypting_time_in_ms 215 (-2%) 602 (-1%) 2,161 (-3%)
note_trial_decrypting_time_in_ms 24.6 (-18%) 42.0 (-17%) 187
l2_block_building_time_in_ms 21,330 84,601 343,204
l2_block_rollup_simulation_time_in_ms 15,998 63,392 258,842
l2_block_public_tx_process_time_in_ms 5,305 21,133 84,115

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,012 (-8%) 29,988 (-6%)
note_history_successful_decrypting_time_in_ms 1,478 (+5%) 2,842 (+5%)
note_history_trial_decrypting_time_in_ms 195 (+17%) 265 (+19%)
node_database_size_in_bytes 18,661,456 36,130,896
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 335 (+1%) 44,664 27,457
private-kernel-ordering 214 45,777 14,627
base-rollup 1,742 175,344 933
root-rollup 83.5 (-1%) 4,192 825
private-kernel-inner 444 73,099 27,457
public-kernel-app-logic 275 32,254 25,379
merge-rollup 7.88 2,712 933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.3 10.7 15.5 (+21%) 17.2 23.0 63.8 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.596 0.593 0.656 (+21%) 0.532 0.479 0.441 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 74.7 48.0 239 474 (+2%) 904 3,544
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.461 0.491 0.435 0.442 (+2%) 0.429 0.427
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 104 57.1 353 (-1%) 692 (+1%) 1,366 (-1%) 5,425
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.495 0.497 (-1%) 0.479 0.473 0.473 0.472
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A 64.6 N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A 110 N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A 0.557 N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,388 36,001

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 578 1,516 (+1%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.0332 (+16%) 656

@ludamad ludamad closed this Aug 22, 2024
@ludamad ludamad deleted the cg/doxygen-eg branch August 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants