Skip to content

chore: Increase benchmark warning threshold for trial decrypt #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalladino merged 1 commit into from
Dec 13, 2023
Merged

chore: Increase benchmark warning threshold for trial decrypt #3602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion yarn-project/scripts/src/benchmarks/markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ const WARNING_DIFF_THRESHOLD = 15;
const SMALL_MS_THRESHOLD = 200;
// What % diff should be considered as a warning for "small" ms measurements
const WARNING_DIFF_THRESHOLD_SMALL_MS = 30;
// What % diff should be considered as a warning for trial_decryption in particular
const WARNING_DIFF_THRESHOLD_TRIAL_DECRYPTION = 75;

const log = createConsoleLogger();

Expand All @@ -30,7 +32,9 @@ function isWarning(row: string, col: string, value: number, base: number | undef
return false;
}
const absPercentDiff = Math.abs(Math.round(((value - base) / base) * 100));
if ((row.endsWith('_ms') || col.endsWith('_ms')) && value < SMALL_MS_THRESHOLD) {
if (row.includes('trial_decrypt') || col.includes('trial_decrypt')) {
return absPercentDiff > WARNING_DIFF_THRESHOLD_TRIAL_DECRYPTION;
} else if ((row.endsWith('_ms') || col.endsWith('_ms')) && value < SMALL_MS_THRESHOLD) {
return absPercentDiff >= WARNING_DIFF_THRESHOLD_SMALL_MS;
} else {
return absPercentDiff > WARNING_DIFF_THRESHOLD;
Expand Down