Skip to content

chore: deterministically sort cached_partial_non_native_field_multiplication across wasm32 and native compilations (duplicate) #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevaundray wants to merge 3 commits into from
Closed

chore: deterministically sort cached_partial_non_native_field_multiplication across wasm32 and native compilations (duplicate) #3431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9ba4bf
deterministically sort `cached_partial_non_native_field_multiplication`
kevaundray Nov 25, 2023
c22db4b
use stable_sort
kevaundray Nov 27, 2023
591e9af
Allow empty commit
kevaundray Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/ultra_circuit_builder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,8 +1665,8 @@ void UltraCircuitBuilder_<Arithmetization>::process_non_native_field_multiplicat
c.b[j] = this->real_variable_index[c.b[j]];
}
}
std::sort(cached_partial_non_native_field_multiplications.begin(),
cached_partial_non_native_field_multiplications.end());
std::stable_sort(cached_partial_non_native_field_multiplications.begin(),
cached_partial_non_native_field_multiplications.end());

auto last = std::unique(cached_partial_non_native_field_multiplications.begin(),
cached_partial_non_native_field_multiplications.end());
Expand Down
11 changes: 6 additions & 5 deletions barretenberg/cpp/src/barretenberg/proof_system/circuit_builder/ultra_circuit_builder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,13 @@ class UltraCircuitBuilder_ : public CircuitBuilderBase<typename Arithmetization:
if (a < other.a) {
return true;
}
if (a == other.a) {
if (b < other.b) {
return true;
}
if (other.a < a) {
return false;
}
if (b < other.b) {
return true;
}
return false;
return other.b < b;
}
};

Expand Down