Skip to content

docs: Adds trivial changes section to contributing guidelines#3355

Closed
darigovresearch wants to merge 1 commit intoAztecProtocol:masterfrom
darigovresearch:contribution-guideline-trivial-change
Closed

docs: Adds trivial changes section to contributing guidelines#3355
darigovresearch wants to merge 1 commit intoAztecProtocol:masterfrom
darigovresearch:contribution-guideline-trivial-change

Conversation

@darigovresearch
Copy link
Contributor

Following details from pull request #3302

Would resolve #3352 if merged

@ludamad
Copy link
Collaborator

ludamad commented Nov 20, 2023

Thank you, although this doesn't spell out what the current policy is, which after some thought is that all changes are welcome but we reserve the right to redo minor PRs in our own PR due to not wanting to encourage trivial changes to farm metrics. The idea with not adding it immediately is that people can continue to make pull requests as usual, just with the policy we'll get them in through a remade PR once ready, so we can potentially leave it as well and we'll message people case-by-case when this has happened

@ludamad
Copy link
Collaborator

ludamad commented Feb 13, 2024

Closed as not planned. Current thinking is we just communicate this as people open PRs but nothing is discouraged and it's just a technical detail of the merge

@ludamad ludamad closed this Feb 13, 2024
@darigovresearch
Copy link
Contributor Author

Thanks for the update @ludamad !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Docs: Add new trivial changes to contributing policy

2 participants