docs: Adds trivial changes section to contributing guidelines#3355
Closed
darigovresearch wants to merge 1 commit intoAztecProtocol:masterfrom
Closed
docs: Adds trivial changes section to contributing guidelines#3355darigovresearch wants to merge 1 commit intoAztecProtocol:masterfrom
darigovresearch wants to merge 1 commit intoAztecProtocol:masterfrom
Conversation
Following details from pull request AztecProtocol#3302 Would resolve AztecProtocol#3352 if merged
Collaborator
|
Thank you, although this doesn't spell out what the current policy is, which after some thought is that all changes are welcome but we reserve the right to redo minor PRs in our own PR due to not wanting to encourage trivial changes to farm metrics. The idea with not adding it immediately is that people can continue to make pull requests as usual, just with the policy we'll get them in through a remade PR once ready, so we can potentially leave it as well and we'll message people case-by-case when this has happened |
Collaborator
|
Closed as not planned. Current thinking is we just communicate this as people open PRs but nothing is discouraged and it's just a technical detail of the merge |
Contributor
Author
|
Thanks for the update @ludamad ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following details from pull request #3302
Would resolve #3352 if merged