chore(docs): build bb.js in docs build script#3306
Closed
critesjosh wants to merge 7 commits intomasterfrom
Closed
chore(docs): build bb.js in docs build script#3306critesjosh wants to merge 7 commits intomasterfrom
critesjosh wants to merge 7 commits intomasterfrom
Conversation
Maddiaa0
reviewed
Nov 14, 2023
docs/scripts/build.sh
Outdated
| echo Working dir $(pwd) | ||
|
|
||
| # Build bb.js | ||
| cd barretenberg/ts |
Member
There was a problem hiding this comment.
Could this follow the same pattern as build_package?
Contributor
Author
There was a problem hiding this comment.
Yes, I can update. I don't think this builds though.
Are you able to build docs (yarn build in ./docs/) on your machine?
Member
There was a problem hiding this comment.
Apologies for the late response, i fell behind on this at istanbul.
I have just run it ok on the mainframe, does netlify have a docker container build option, if its not building there its probably due to the lack of required dependencies like clang16 etc.
Maddiaa0
approved these changes
Nov 20, 2023
Contributor
Author
|
I think the better solution is to use netlify CLI in our build pipeline and push the built site to netlify. See #3336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs need to build the latest bb.js now to build correctly, after this PR.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.