fix: Fix block constraint key divergence bug.

[charlielye]

• Fixes the "bad witness key divergence bug" in RAM block constraint by creating new witness and asserting it's equal to the original witness.
• Adds a new prove_then_verify test flow, which is used to always exercise the good/bad witness data paths to ensure the resulting keys are the same. This is faster than all_cmds which isn't needed for every test. It's slower than prove_and_verify which uses the single built in command, but that's less safe as it only exercised the bad witness path for circuit construction.
• Limit hardware concurrency to 16 cores as performance can actually be worse with higher core counts.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 2da5febc and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,900	868,172	3,448,088
l1_rollup_execution_gas	841,987	3,595,280	22,203,457
l2_block_processing_time_in_ms	1,988 (+1%)	7,525 (-1%)	29,677
note_successful_decrypting_time_in_ms	294	869 (+1%)	3,174 (-1%)
note_trial_decrypting_time_in_ms	95.0 (-2%)	77.0 (+7%)	137 (+1%)
l2_block_building_time_in_ms	13,220 (-1%)	52,978 (+1%)	209,319
l2_block_rollup_simulation_time_in_ms	11,822 (-1%)	47,665 (+1%)	188,122
l2_block_public_tx_process_time_in_ms	1,359 (+5%)	5,179	20,711

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,742	42,362 (+1%)
note_history_successful_decrypting_time_in_ms	1,994	3,898
note_history_trial_decrypting_time_in_ms	120	144 (+1%)
node_database_size_in_bytes	1,630,709	1,101,682
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	770	61,697	18,905
private-kernel-ordering	123	24,297	8,153
base-rollup	1,774	656,311	814
root-rollup	75.5 (-3%)	4,072	1,097
private-kernel-inner	786	81,568	18,905
public-kernel-private-input	41.5	41,519	18,841
public-kernel-non-first-iteration	26.3	41,497	18,841
merge-rollup	0.920 (-2%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547

[Maddiaa0]

little gotcha when merging master; will defer review to @kevaundray

[Maddiaa0]

After a master merge this will have to be removed in main.ts for bb.js

[Maddiaa0]

kev walked me through it, lgtm