Skip to content

fix: yarn prepare #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 3 commits into from
Nov 6, 2023
Merged

fix: yarn prepare #3251

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c44703
fix: yarn prepare
ludamad Nov 6, 2023
780566f
fix: more lenient package.json check
Nov 6, 2023
4950624
fix: export right types from noir-contracts
Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion yarn-project/noir-contracts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "module",
"exports": {
"./artifacts": "./dest/artifacts/index.js",
"./types": "./dest/types/index.js"
"./types": "./dest/index.d.ts"

@alexghr alexghr Nov 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think types needs to go as a top-level key to make it pass the check.

@ludamad ludamad Nov 6, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the fix? not sure what you mean

},
"scripts": {
"build": "yarn clean && tsc -b",
Expand Down