chore: noir protocol circuits - stop committing artifacts#3250
Closed
chore: noir protocol circuits - stop committing artifacts#3250
Conversation
rahul-kothari
pushed a commit
that referenced
this pull request
Nov 7, 2023
This PR updates the wasm-compiler to recognize, but not accept the `bin` package type in a Nargo.toml file. Previously it would knew about `binary` but the correct value is `bin`. A couple of commits taken from #3250 --------- Co-authored-by: Dan Lee <dan@aztecprotocol.com>
Contributor
Author
|
going to close as this was trying to use noir-wasm, and i believe we are re-focusing on nargo now that we have semi-integrated the repos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build on CI, stop committing them as is. This is similar to how we handle the
noir-contractscompilation artifactsrunning into issues using the new noir-wasm compiler/CLI, which seem to assume the nargo package is
contracttype (as opposed to lib/bin)