feat!: tree leaf value as Fr everywhere in our public API

[benesjan]

Fixes #3172

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit db67aa1e and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,960	867,836	3,449,480
l1_rollup_execution_gas	842,047	3,594,944	22,204,849
l2_block_processing_time_in_ms	1,945 (-3%)	7,532 (-1%)	29,450 (-1%)
note_successful_decrypting_time_in_ms	294 (+2%)	852	3,111 (-4%)
note_trial_decrypting_time_in_ms	95.0 (+2%)	59.0 (-3%)	134 (-1%)
l2_block_building_time_in_ms	13,096 (-1%)	52,078	207,278 (-1%)
l2_block_rollup_simulation_time_in_ms	11,786 (-1%)	46,854	186,431 (-1%)
l2_block_public_tx_process_time_in_ms	1,273	5,094	20,370 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,419 (-1%)	42,110
note_history_successful_decrypting_time_in_ms	1,985 (-3%)	3,888 (-2%)
note_history_trial_decrypting_time_in_ms	121	144 (-23%)
node_database_size_in_bytes	1,629,287	1,098,934
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	72.1	61,697	18,841
private-kernel-ordering	43.4	24,233	8,089
base-rollup	1,771	656,309	811
root-rollup	79.5 (+2%)	4,072	1,097
private-kernel-inner	53.0 (-1%)	81,504	18,841
public-kernel-private-input	41.3 (-1%)	41,455	18,841
public-kernel-non-first-iteration	26.3 (-1%)	41,497	18,841
merge-rollup	0.891 (-2%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,723	27,240

[Maddiaa0]

lgtm, ive just pointed out some more inconsistencies in the review but will not block this work on its behalf

[Maddiaa0]

should the find leaf index api also use Fr ?

[benesjan]

I felt like changing the types in the merkle tree package could get a bit tricky in some places we pass the serialized indexed tree value which should not be Fr. Also we'll nuke the whole package and replace it with Rust or C++ so it's probably ok to keep the code disgusting.

[Maddiaa0]

wait hold up above uses buffer and this uses FR?

[benesjan]

I am AFK already so I merged it and I will consider addressing this tomorrow.

[Maddiaa0]

Heres another area where there is inconsistency:

getPublicStorage at sometimes has a bigint and sometimes has a field, as this is just an index, im in favour of this being just a bigint