fix: use standard serialized vector of frs in function tree cbinds

[dbanks12]

Description

• Closes Use read in c_binds, rather than custom buffer manipulation aztec3-circuits#203
• Closes abis__compute_function_tree_root and abis__compute_function_tree should use vectors instead of raw buffers #218
• Blocked by fix: enforce correct length of hashConstructor args #321

Contents

• update function tree cbinds to expect a vector of frs using standard serialization
• revert TS to use serializeBufferArrayToVector again for cbind args now that C++ expects vectors
• rename/cleanup cbind arg names and remove num_leaves arg (not necessary since size of vec is first word of serialization)
• remove unnecessary tree helper functions in C++ and replace with simpler helper
• some autoformatting of C++ from an unformatted merge commit

Checklist:

• I have reviewed my diff in github, line by line.
• Every change is related to the PR description.
• I have linked this pull request to the issue(s) that it resolves.
• There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
• The branch has been merged or rebased against the head of its merge target.
• I'm happy for the PR to be merged at the reviewer's next convenience.

[ludamad]

Lgtm

…

On Thu, Apr 20, 2023, 10:36 AM David Banks ***@***.***> wrote: Description Please provide a paragraph or two giving a summary of the change, including relevant motivation and context. Checklist: - I have reviewed my diff in github, line by line. - Every change is related to the PR description. - I have linked <https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue> this pull request to the issue(s) that it resolves. - There are no unexpected formatting changes, superfluous debug logs, or commented-out code. - The branch has been merged or rebased against the head of its merge target. - I'm happy for the PR to be merged at the reviewer's next convenience. ------------------------------ You can view, comment on, or merge this pull request online at: #314 Commit Summary - 1b5402b <1b5402b> use a plain old serialized vector of frs instead of doing manual serialization logic for leaf frs File Changes (3 files <https://github.com/AztecProtocol/aztec3-packages/pull/314/files> ) - *M* circuits/cpp/src/aztec3/circuits/abis/c_bind.cpp <https://github.com/AztecProtocol/aztec3-packages/pull/314/files#diff-2496d2735ce4a0673043dbad1ea49b3f587eaf49a20d71564b22b3e4b06830a4> (142) - *M* circuits/cpp/src/aztec3/circuits/abis/c_bind.h <https://github.com/AztecProtocol/aztec3-packages/pull/314/files#diff-34a02ce73ffd12364262c25c93b85d9a3630fa4e1521ad6b904033ef751874f7> (2) - *M* circuits/cpp/src/aztec3/circuits/abis/c_bind.test.cpp <https://github.com/AztecProtocol/aztec3-packages/pull/314/files#diff-47a2dd92ffb322c6257ec1a891c98471db1b54be7bd0d75c39a4a3aa328e64cd> (92) Patch Links: - https://github.com/AztecProtocol/aztec3-packages/pull/314.patch - https://github.com/AztecProtocol/aztec3-packages/pull/314.diff — Reply to this email directly, view it on GitHub <#314>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABIBGIQCAYMEDENIMTEPCLXCFCWBANCNFSM6AAAAAAXFTFPQM> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Maddiaa0]

Do we eventually want to have this also be 0, as we did for the NullifierTree?

[dbanks12]

Not sure, what are advantages of each way?