Conversation
Maddiaa0
force-pushed
the
md/zero-indexed-tree
branch
from
7898d38 to
800760a
Compare
LHerskind
approved these changes
Apr 18, 2023
Contributor
LHerskind
left a comment
LHerskind
left a comment
There was a problem hiding this comment.
Minor nitpicks, otherwise chefs kiss. If you address those good to merge for me.
The comments on the indexes tree for getSiblingPath are not completed, only one param is defined. Adding a bit more info for includeUncommited would be nice, however seems like it is all the way down to the lowest level where it was not outlined.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked Ticket: AztecProtocol/aztec3-circuits#161
Depends on: AztecProtocol/barretenberg#360
Test passing blocked by:
#293
Checklist: