Skip to content

chore: enable noir private kernel circuit init #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirasistant merged 21 commits into from
Oct 11, 2023
Merged

chore: enable noir private kernel circuit init #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f2ad8b1
add package.json and initial test
kevaundray Oct 10, 2023
45f2c34
add FixedLengthArray and change ReturnType to be an alias of the type…
kevaundray Oct 10, 2023
cd013f7
modify noir code to fix bug
kevaundray Oct 10, 2023
03f47ec
regenerate bindings
kevaundray Oct 10, 2023
6d6f9b9
modify type conversion code to cast to FixedSizeArrayLength -- typesc…
kevaundray Oct 10, 2023
f3f9f57
refactor test
kevaundray Oct 10, 2023
2a287b6
remove .only
kevaundray Oct 10, 2023
2bd6ac6
Merge remote-tracking branch 'origin/feature_branch/private-kernel' i…
kevaundray Oct 11, 2023
5b6572f
fix import
kevaundray Oct 11, 2023
105401e
remove now redundant test and cleanup import
kevaundray Oct 11, 2023
c886083
move logic to abiEncode/Decode and execute into a function in index.ts
kevaundray Oct 11, 2023
737c6ca
comment update
kevaundray Oct 11, 2023
6ed7f92
tech debt: expose makePrivateKernelInputsInit
kevaundray Oct 11, 2023
f5261c6
redo tests to use executeInit
kevaundray Oct 11, 2023
93d33c5
given makePrivateKernelInputsInit, we can remove the manual instance …
kevaundray Oct 11, 2023
b2c4841
replace `privateKernelSimInit` with Noir private kernel version
kevaundray Oct 11, 2023
1dd0d63
remove if statement as its always false -- noir private kernel does n…
kevaundray Oct 11, 2023
1f77fd8
yarn formatting
kevaundray Oct 11, 2023
7577f53
Merge branch 'kw/abi-types-encoding' into kw/enable-noir-private-kernel
kevaundray Oct 11, 2023
541017c
Merge branch 'feature_branch/private-kernel' into kw/enable-noir-priv…
sirasistant Oct 11, 2023
b1dd78a
style: fixed formatting
sirasistant Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions yarn-project/pxe/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"@aztec/foundation": "workspace:^",
"@aztec/key-store": "workspace:^",
"@aztec/noir-compiler": "workspace:^",
"@aztec/noir-private-kernel": "workspace:^",
"@aztec/types": "workspace:^",
"koa": "^2.14.2",
"koa-router": "^12.0.0",
Expand Down
9 changes: 3 additions & 6 deletions yarn-project/pxe/src/kernel_prover/proof_creator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ import {
PrivateKernelInputsOrdering,
Proof,
makeEmptyProof,
privateKernelSimInit,
privateKernelSimInner,
privateKernelSimOrdering,
} from '@aztec/circuits.js';
import { siloCommitment } from '@aztec/circuits.js/abis';
import { Fr } from '@aztec/foundation/fields';
import { createDebugLogger } from '@aztec/foundation/log';
import { elapsed } from '@aztec/foundation/timer';
import { executeInit } from '@aztec/noir-private-kernel';

/**
* Represents the output of the proof creation process for init and inner private kernel circuit.
Expand Down Expand Up @@ -108,11 +108,8 @@ export class KernelProofCreator implements ProofCreator {
}

public async createProofInit(privateInputs: PrivateKernelInputsInit): Promise<ProofOutput> {
const wasm = await CircuitsWasm.get();
const [time, result] = await elapsed(() => privateKernelSimInit(wasm, privateInputs));
if (result instanceof CircuitError) {
throw new CircuitError(result.code, result.message);
}
const [time, result] = await elapsed(() => executeInit(privateInputs));

this.log(`Simulated private kernel init`, {
eventName: 'circuit-simulation',
circuitName: 'private-kernel-init',
Expand Down
3 changes: 3 additions & 0 deletions yarn-project/pxe/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
{
"path": "../noir-compiler"
},
{
"path": "../noir-private-kernel"
},
{
"path": "../types"
}
Expand Down
3 changes: 2 additions & 1 deletion yarn-project/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ __metadata:
languageName: unknown
linkType: soft

"@aztec/noir-private-kernel@workspace:noir-private-kernel":
"@aztec/noir-private-kernel@workspace:^, @aztec/noir-private-kernel@workspace:noir-private-kernel":
version: 0.0.0-use.local
resolution: "@aztec/noir-private-kernel@workspace:noir-private-kernel"
dependencies:
Expand Down Expand Up @@ -720,6 +720,7 @@ __metadata:
"@aztec/foundation": "workspace:^"
"@aztec/key-store": "workspace:^"
"@aztec/noir-compiler": "workspace:^"
"@aztec/noir-private-kernel": "workspace:^"
"@aztec/types": "workspace:^"
"@jest/globals": ^29.5.0
"@rushstack/eslint-patch": ^1.1.4
Expand Down