Skip to content

fix: avoid ambiguity on blank and blank-react (prefix issue) #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dan-aztec merged 1 commit into from
Oct 6, 2023
Merged

fix: avoid ambiguity on blank and blank-react (prefix issue) #2729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions yarn-project/cli/src/unbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ async function downloadContractAndBoxFromGithub(
// small string conversion, in the ABI the contract name looks like PrivateToken
// but in the repostory it looks like private_token

log(`Downloading @aztex/boxes/${contractName} to ${outputPath}...`);
log(`Downloading @aztex/boxes/${contractName}/ to ${outputPath}...`);
// Step 1: Fetch the monorepo ZIP from GitHub, matching the CLI version
const url = `https://github.com/${GITHUB_OWNER}/${GITHUB_REPO}/archive/refs/tags/${tag}.zip`;
const response = await fetch(url);
Expand All @@ -116,7 +116,7 @@ async function downloadContractAndBoxFromGithub(
// this is currently only implemented for `blank` and `private-token` under 'boxes/{box-name}/'
const repoDirectoryPrefix = `${GITHUB_REPO}-${tag}`;

const boxPath = `${repoDirectoryPrefix}/${BOXES_PATH}/${contractName}`;
const boxPath = `${repoDirectoryPrefix}/${BOXES_PATH}/${contractName}/`;
await copyFolderFromGithub(data, boxPath, outputPath, log);

// the expected noir version is contained in
Expand Down