Skip to content

chore: Remove build system tainting now we have ci cmds in comments. #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlielye merged 1 commit into from
Sep 28, 2023
Merged

chore: Remove build system tainting now we have ci cmds in comments. #2589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build-system/scripts/build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ cd $BUILD_DIR
# If we have previously successful commit, we can early out if nothing relevant has changed since.
if [[ $FORCE_BUILD == 'false' ]] && check_rebuild cache-"$CONTENT_HASH" $REPOSITORY; then
echo "No rebuild necessary."
untag_remote_image $REPOSITORY tainted
exit 0
fi

Expand Down
6 changes: 0 additions & 6 deletions build-system/scripts/check_rebuild
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,7 @@ REPOSITORY=$2
[[ "$COMMIT_MESSAGE" == *"[ci rebuild]"* ]] && exit 1

if ! image_exists $REPOSITORY $TAG; then
echo "Rebuild required."
exit 1
elif image_exists $REPOSITORY tainted; then
# If a tainted tag exists, remove it and exit with failure to rebuild.
echo "$REPOSITORY has been tainted. Will rebuild."
exit 1
else
echo "No rebuild required."
exit 0
fi