Skip to content

fix: Fix working dir bug causing stdlib-tests to not run. #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlielye merged 2 commits into from
Sep 25, 2023
Merged

fix: Fix working dir bug causing stdlib-tests to not run. #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12eb2fb
Fix working dir.
charlielye Sep 25, 2023
f3df7bd
Add scripts folder to rebuild patterns.
charlielye Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion barretenberg/cpp/.rebuild_patterns
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
^barretenberg/.*\\.(cpp|cc|cxx|c\\+\\+|h|hpp|hxx|h\\+\\+|c|h|inl|inc|ipp|tpp|cmake)$
^barretenberg/.*CMakeLists\\.txt$
^barretenberg/.*Dockerfile.*$
^barretenberg/.*Dockerfile.*$
Copy link
Copy Markdown
Collaborator

@ludamad ludamad Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to add barretenberg/cpp/scripts here?

Copy link
Copy Markdown
Contributor Author

@charlielye charlielye Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The stdlib tests were not being re-run despite changing the script that runs them.
Future should be better when tests are listed independently in build manifest.

^barretenberg/scripts/
3 changes: 2 additions & 1 deletion barretenberg/cpp/scripts/run_tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ IMAGE_URI=$(calculate_image_uri $REPOSITORY)
retry docker pull $IMAGE_URI

# If there is a file in the scripts directory named $TESTS, those are the tests to run.
if [ -f "$(query_manifest projectDir $REPOSITORY)/scripts/$TESTS" ]; then
cd $(query_manifest projectDir $REPOSITORY)/scripts
if [ -f "$TESTS" ]; then
TESTS=$(cat $TESTS | tr '\n' ' ')
fi

Expand Down