Skip to content

chore: unskip test and fix params #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahul-kothari merged 2 commits into from
Sep 21, 2023
Merged

chore: unskip test and fix params #2454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d9e4c7
unskip test and fix params
rahul-kothari Sep 21, 2023
fa4e5ef
Merge branch 'master' into rk/cross_chain_comm_fixes
sirasistant Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions yarn-project/end-to-end/src/e2e_cross_chain_messaging.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ describe('e2e_cross_chain_messaging', () => {
await crossChainTestHarness?.stop();
});

it.skip('Milestone 2: Deposit funds from L1 -> L2 and withdraw back to L1', async () => {
it('Milestone 2: Deposit funds from L1 -> L2 and withdraw back to L1', async () => {
// Generate a claim secret using pedersen
const l1TokenBalance = 1000000n;
const bridgeAmount = 100n;
Expand Down Expand Up @@ -97,9 +97,9 @@ describe('e2e_cross_chain_messaging', () => {
// 3. Consume L1-> L2 message and mint private tokens on L2
await crossChainTestHarness.consumeMessageOnAztecAndMintSecretly(
bridgeAmount,
secretHashForRedeemingMintedNotes,
messageKey,
secretForL2MessageConsumption,
secretHashForRedeemingMintedNotes,
);
// tokens were minted privately in a TransparentNote which the owner (person who knows the secret) must redeem:
await crossChainTestHarness.redeemShieldPrivatelyOnL2(bridgeAmount, secretForRedeemingMintedNotes);
Expand Down