Skip to content

fix: dockerfiles not part of rebuild#2261

Merged
ludamad merged 2 commits intomasterfrom
ad/revert-cpp-build-pattern
Sep 12, 2023
Merged

fix: dockerfiles not part of rebuild#2261
ludamad merged 2 commits intomasterfrom
ad/revert-cpp-build-pattern

Conversation

@ludamad
Copy link
Collaborator

@ludamad ludamad commented Sep 12, 2023

This reverts commit 21c2f8e. This missed dockerfiles. The idea of not matching .gitrepo files was not worth it. This caused hidden issues when changing ubuntu versions.

@ludamad ludamad enabled auto-merge (squash) September 12, 2023 22:35
@ludamad ludamad changed the title Revert "fix: More accurate c++ build pattern (#1962)" chore: revert More accurate c++ build pattern (#1962) Sep 12, 2023
@ludamad ludamad requested a review from charlielye September 12, 2023 22:36
@ludamad ludamad changed the title chore: revert More accurate c++ build pattern (#1962) fix: ubuntu change caused uncaught breakage Sep 12, 2023
@ludamad ludamad changed the title fix: ubuntu change caused uncaught breakage fix: dockerfiles not part of rebuild Sep 12, 2023
@ludamad ludamad force-pushed the ad/revert-cpp-build-pattern branch from 4f70cff to 8615926 Compare September 12, 2023 22:59
Copy link
Contributor

@ledwards2225 ledwards2225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ludamad ludamad merged commit dca21c3 into master Sep 12, 2023
@ludamad ludamad deleted the ad/revert-cpp-build-pattern branch September 12, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants