Skip to content

fix: reinstate v stripping in build #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilWindle merged 1 commit into from
Sep 12, 2023
Merged

fix: reinstate v stripping in build #2220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions build-system/scripts/build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,9 @@ if [[ -n "$COMMIT_TAG" ]]; then
COMMIT_TAG_VERSION=$COMMIT_TAG
fi

## We are building a tagged commit. Check it's a valid semver.
#VERSION=$(npx semver $COMMIT_TAG_VERSION)
#if [ -z "$VERSION" ]; then
# COMMIT_TAG_VERSION=""
#else
# COMMIT_TAG_VERSION=$VERSION
#fi
# We are building a tagged commit.
# We prefer to strip the leading 'v' (if it exists) from versions when passing to docker.
COMMIT_TAG_VERSION=${COMMIT_TAG_VERSION#v}
else
COMMIT_TAG_VERSION=""
fi
Expand Down