Conversation
## Summary The nightly barretenberg debug build was only compiling (`bootstrap.sh build`) but never running tests. This meant debug-only assertions (like the `uint256::slice` bounds check that caught an incorrect parameter in #21723) were never exercised in CI. - Change `ci-barretenberg-debug` bootstrap target from `build` to `ci` (build + test) - Bump EC2 resources: 16 → 32 CPUs, add 120min shutdown time (debug tests are ~2x slower) **Manual follow-up needed**: Update `.github/workflows/barretenberg-nightly-debug-build.yml` timeout from 120 to 240 minutes (workflow files are blocked from this session). ## Context #21723 — Federico discovered that `uint256::slice` only asserts `start >= end` in debug mode. Tests passed in release CI despite incorrect parameters due to silent wraparound. Running debug tests nightly will catch these kinds of issues. ClaudeBox log: https://claudebox.work/s/99cbf067abf65f72?run=1 --------- Co-authored-by: ludamad <adam.domurad@gmail.com>
Adds some tests of the sha256 hash gadget under various mixed constant-witness cases. Also removes buggy but unused logic from the `sparse_value` constructor related to constant values
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: run tests in nightly debug build (#21791)
chore: sha tests for mixed constant-witness inputs (#21123)
END_COMMIT_OVERRIDE