refactor: revert remove assert_bounded_vec_trimmed

noir-projects/aztec-nr/aztec/src/oracle/aes128_decrypt.nr

@@ -1,5 +1,3 @@
-use crate::utils::array::assert_bounded_vec_trimmed;
-
 #[oracle(aztec_utl_tryAes128Decrypt)]
 unconstrained fn try_aes128_decrypt_oracle<let N: u32>(
     ciphertext: BoundedVec<u8, N>,
@@ -21,10 +19,7 @@ pub unconstrained fn try_aes128_decrypt<let N: u32>(
     iv: [u8; 16],
     sym_key: [u8; 16],
 ) -> Option<BoundedVec<u8, N>> {
-    try_aes128_decrypt_oracle(ciphertext, iv, sym_key).map(|result: BoundedVec<u8, N>| {
-        assert_bounded_vec_trimmed(result);
-        result
-    })
+    try_aes128_decrypt_oracle(ciphertext, iv, sym_key)
 }
 
 mod test {

noir-projects/aztec-nr/aztec/src/oracle/notes.nr

@@ -1,5 +1,4 @@
 use crate::note::{HintedNote, note_interface::NoteType};
-use crate::utils::array::assert_bounded_vec_trimmed;
 
 use crate::protocol::{address::AztecAddress, traits::Packable};
 
@@ -143,7 +142,6 @@ where
         MaxNotes,
         <HintedNote<Note> as Packable>::N,
     );
-    assert_bounded_vec_trimmed(packed_hinted_notes);
 
     let mut notes = BoundedVec::<_, MaxNotes>::new();
     for i in 0..packed_hinted_notes.len() {
@@ -170,9 +168,7 @@ where
     // both a preprocessor and a filter.
     let mut notes_array = [Option::none(); MaxNotes];
     for i in 0..notes.len() {
-        if i < notes.len() {
-            notes_array[i] = Option::some(notes.get_unchecked(i));
-        }
+        notes_array[i] = Option::some(notes.get_unchecked(i));
     }
 
     notes_array

noir-projects/aztec-nr/aztec/src/utils/array/mod.nr

@@ -1,11 +1,9 @@
 pub mod append;
-pub mod assert_trimmed;
 pub mod collapse;
 pub mod subarray;
 pub mod subbvec;
 
 pub use append::append;
-pub(crate) use assert_trimmed::assert_bounded_vec_trimmed;
 pub use collapse::collapse;
 pub use subarray::subarray;
 pub use subbvec::subbvec;