fix: bad backport in checkpoint_builder.test.ts — wrong addBlock mock return type#21720
Open
AztecBot wants to merge 1 commit intobackport-to-v4-next-stagingfrom
Open
fix: bad backport in checkpoint_builder.test.ts — wrong addBlock mock return type#21720AztecBot wants to merge 1 commit intobackport-to-v4-next-stagingfrom
AztecBot wants to merge 1 commit intobackport-to-v4-next-stagingfrom
Conversation
AztecBot
added
ci-draft
alexghr
changed the base branch from
merge-train/spartan
to
backport-to-v4-next-staging
alexghr
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TS2353 build error on
backport-to-v4-next-staging:The backport of PR #21520 introduced
{ block, timings: {} }as the mock return value foraddBlock, matching thenextbranch API. But on v4-next,LightweightCheckpointBuilder.addBlock()returnsPromise<L2Block>directly — no wrapper object.Fixed by changing the mock from
{ block, timings: {} }to justblock.ClaudeBox log: https://claudebox.work/s/43f5e24bef7fdf69?run=1