chore: add slack success post on nightly scenario#21701
Merged
danielntmd merged 1 commit intomerge-train/spartanfrom Mar 17, 2026
Merged
chore: add slack success post on nightly scenario#21701danielntmd merged 1 commit intomerge-train/spartanfrom
danielntmd merged 1 commit intomerge-train/spartanfrom
Conversation
ludamad
reviewed
Mar 17, 2026
ci3/run_test_cmd
Outdated
| fi | ||
|
|
||
| if [ "$slack_notify_pass" -eq 1 ]; then | ||
| slack_notify "Test PASSED on *${TARGET_BRANCH:-$REF_NAME}*: \`$test_cmd\` $DASHBOARD_URL/$log_key" "#alerts-next-scenario" |
Collaborator
There was a problem hiding this comment.
hmm why both?
my preference is to have the slack posted inside the ci job handling, not here nor in in GA but in bootstrap.sh with a call like this
Contributor
Author
There was a problem hiding this comment.
Very simple PR now. It's both still because bootstrap.sh can't keep track of both deployment states.
Contributor
Author
There was a problem hiding this comment.
If we want 1 message, we need a downstream GA job in ci3.yml
danielntmd
force-pushed
the
danielntmd/post-slack-scenario-success
branch
3 times, most recently
from
de9e2e1 to
7bef3ef
Compare
danielntmd
force-pushed
the
danielntmd/post-slack-scenario-success
branch
from
7bef3ef to
4c2210e
Compare
Contributor
Author
|
Sorry for push after review, added extra label to distinguish which scenario set passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will report both legs of the scenario tests.