fix: HA deadlock for last block edge case#21690
Merged
spypsy merged 1 commit intomerge-train/spartanfrom Mar 17, 2026
Merged
Conversation
alexghr
approved these changes
Mar 17, 2026
|
|
||
| if (!lastBlockInfo) { | ||
| return new CheckpointProposal(checkpointHeader, archiveRoot, feeAssetPriceModifier, checkpointSignature); | ||
| let checkpointSignature: Signature; |
Contributor
There was a problem hiding this comment.
Ah we don't really need this variable here since inside the if we just early return. I'd move this to after the if statement and turn it into a const.
spypsy
force-pushed
the
spy/fix-ha-last-block
branch
from
caabe39 to
1eb8594
Compare
AztecBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
change ordering for `lastBlock` case when creating a checkpoint proposal, so that we first sign the last block and then the checkpoint
Collaborator
|
✅ Successfully backported to backport-to-v4-staging #21694. |
ludamad
pushed a commit
that referenced
this pull request
Mar 17, 2026
change ordering for `lastBlock` case when creating a checkpoint proposal, so that we first sign the last block and then the checkpoint
ludamad
added a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change ordering for
lastBlockcase when creating a checkpoint proposal, so that we first sign the last block and then the checkpoint