Skip to content

fix: skip -march auto-detection when cross-compiling #21653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AztecBot wants to merge 1 commit into
base: merge-train/spartan
Choose a base branch
from
Draft

fix: skip -march auto-detection when cross-compiling #21653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions barretenberg/cpp/cmake/arch.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@ if(WASM)
add_compile_options(-fno-exceptions -fno-slp-vectorize)
endif()

# Auto-detect TARGET_ARCH if not explicitly set.
# Use 'skylake' on x86_64 (matches our cross-compile presets) and 'generic' on ARM
# to avoid emitting CPU-specific instructions (e.g. SVE on Graviton) that break on
# other ARM machines like Apple Silicon.
if(NOT WASM AND NOT TARGET_ARCH)
if(ARM)
set(TARGET_ARCH "generic")
else()
# Auto-detect TARGET_ARCH for native (non-cross) builds only.
# Cross-compilation presets already specify the target via -target/-mcpu flags;
# auto-detecting based on the HOST architecture would set the wrong -march
# (e.g. -march=skylake when cross-compiling to aarch64).
# For native x86_64 builds, default to 'skylake'.
# For native ARM builds, skip -march entirely — the zig wrapper scripts handle
# the target architecture, and -march=generic can conflict with -mcpu flags.
if(NOT WASM AND NOT TARGET_ARCH AND NOT CMAKE_CROSSCOMPILING)
if(NOT ARM)
set(TARGET_ARCH "skylake")
endif()
endif()
Expand Down
Loading