feat: gas estimations on send#21646
Merged
Thunkar merged 14 commits intomerge-train/fairiesfrom Mar 18, 2026
Merged
Conversation
…packages into gj/gas_estimations_on_send
Thunkar
added
the
ci-no-fail-fast
benesjan
reviewed
Mar 17, 2026
yarn-project/aztec.js/src/authorization/call_authorization_request.ts
Outdated
Show resolved
Hide resolved
mverzilli
reviewed
Mar 17, 2026
yarn-project/pxe/src/contract_function_simulator/contract_function_simulator.ts
Show resolved
Hide resolved
mverzilli
reviewed
Mar 17, 2026
mverzilli
reviewed
Mar 17, 2026
nventuro
reviewed
Mar 17, 2026
| ); | ||
| const { from, feeOptions, scopes, skipTxValidation, skipFeeEnforcement } = opts; | ||
| const skipKernels = this.simulationMode !== 'full'; | ||
| const useOverride = this.simulationMode === 'kernelless-override' && !from.equals(AztecAddress.ZERO); |
Contributor
There was a problem hiding this comment.
Should this maybe be an error, or should we instead take an enum or something? It feels weird to specify override but then not get overrides.
Contributor
Author
There was a problem hiding this comment.
This is going away with NO_FROM
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
AztecBot
pushed a commit
that referenced
this pull request
Mar 18, 2026
EmbeddedWallet now simulates before sending in order to estimate gas and capture autwitness data. This PR also adds validation to captured authwitnesses from offchaineffects (ensuring the inner hash matches the emitted preimage) and fee payer handling to kernelless simulations Closes: https://linear.app/aztec-labs/issue/F-402/estimate-gas-limits-for-a-tx-if-not-provided-by-the-caller Closes: https://linear.app/aztec-labs/issue/F-403/compute-gas-limits-for-private-only-txs --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #21654. |
This was referenced Mar 18, 2026
Thunkar
added a commit
that referenced
this pull request
Mar 19, 2026
## Summary Backports #21716 to v4-next via `backport-to-v4-next-staging`. Based on latest `backport-to-v4-next-staging` which has #21646 (gas estimations on send), so this PR contains only #21716's actual changes (NO_FROM pattern). Cherry-pick conflicts resolved: - `bot/src/factory.ts` — `AztecAddress.ZERO` → `NO_FROM` - `e2e_fees/account_init.test.ts` — `AztecAddress.ZERO` → `NO_FROM` - `docs/examples/ts/recursive_verification/index.ts` — imports + data loading updated - `docs/examples/ts/aztecjs_connection/index.ts` — `AztecAddress.ZERO` → `NO_FROM` in existing fee juice section, discarded duplicate sections from cherry-pick - `spartan/block_capacity.test.ts` — deleted (already removed on v4-next) ## Key changes - Introduces `NO_FROM` pattern replacing `AztecAddress.ZERO` sentinel for bypassing account contract entrypoint - Removes `SignerlessAccountContract` - Uses `DefaultEntrypoint` directly when `from: NO_FROM` - Deshrines `MulticallEntrypoint` from wallet internals --------- Co-authored-by: Gregorio Juliana <gregojquiros@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbeddedWallet now simulates before sending in order to estimate gas and capture autwitness data.
This PR also adds validation to captured authwitnesses from offchaineffects (ensuring the inner hash matches the emitted preimage) and fee payer handling to kernelless simulations
Closes: https://linear.app/aztec-labs/issue/F-402/estimate-gas-limits-for-a-tx-if-not-provided-by-the-caller
Closes: https://linear.app/aztec-labs/issue/F-403/compute-gas-limits-for-private-only-txs