fix: add bounds when allocating arrays in deserialization#21622
Merged
PhilWindle merged 2 commits intomerge-train/spartanfrom Mar 17, 2026
Merged
fix: add bounds when allocating arrays in deserialization#21622PhilWindle merged 2 commits intomerge-train/spartanfrom
PhilWindle merged 2 commits intomerge-train/spartanfrom
Conversation
spalladino
added
ci-no-fail-fast
Calling `Array.from({length})` allocates length immediately. We were
calling this method in the context of deserialization with untrusted
input.
This PR changes it so we use `new Array(size)` for untrusted input. A
bit less efficient, but more secure.
spalladino
force-pushed
the
palla/a-696-deserialization-max-size-bounds
branch
from
5786cad to
92f87f8
Compare
spalladino
changed the title
spalladino
changed the title
PhilWindle
approved these changes
Mar 17, 2026
AztecBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Calling `Array.from({length})` allocates length immediately. We were
calling this method in the context of deserialization with untrusted
input.
This PR changes it so we use `new Array(size)` for untrusted input. A
bit less efficient, but more secure.
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #21654. |
spalladino
added a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Array.from({length})allocates length immediately. We werecalling this method in the context of deserialization with untrusted
input.
This PR changes it so we use
new Array(size)for untrusted input. Abit less efficient, but more secure.