Skip to content

fix: backport remove insecure SchnorrSingleKeyAccount contract to v4-next#21548

Merged
nchamo merged 10 commits intobackport-to-v4-next-stagingfrom
claudebox/backport-remove-schnorr-account-v4
Mar 13, 2026
Merged

fix: backport remove insecure SchnorrSingleKeyAccount contract to v4-next#21548
nchamo merged 10 commits intobackport-to-v4-next-stagingfrom
claudebox/backport-remove-schnorr-account-v4

Conversation

@AztecBot
Copy link
Collaborator

Summary

Backport of #20766 to v4-next.

The SchnorrSingleKeyAccount contract and its TypeScript wrapper SingleKeyAccountContract have been removed. This contract was insecure: it used ivpk_m (incoming viewing public key) as its Schnorr signing key, meaning anyone who received a user's viewing key could sign transactions on their behalf.

Cherry-pick conflict resolution

The automatic cherry-pick failed due to a conflict in docs/docs-developers/docs/resources/migration_notes.md. The v4-next branch had additional migration notes (getPublicEvents, simulate/send return types, aztec new changes) that don't exist on the original PR's base. Resolution: kept all v4-next content and added the SingleKeyAccountContract removal note at the top of the TBD section.

Commits

  1. Cherry-pick commit — raw cherry-pick of merge commit 98363a7 with conflict markers preserved
  2. Conflict resolution — resolved migration_notes.md conflict, keeping v4-next content + adding removal note
  3. Build fix — updated auto-generated CLI reference doc to match new create-account description

ClaudeBox log: https://claudebox.work/s/6d5d6c906edf05f9?run=1

aminsammara and others added 7 commits March 13, 2026 11:45
## Summary
- Lower `SLASH_INACTIVITY_TARGET_PERCENTAGE` from 0.8 to 0.7
- Disable `SLASH_DUPLICATE_PROPOSAL_PENALTY` and
`SLASH_DUPLICATE_ATTESTATION_PENALTY` (set to 0)
- Increase `SLASH_GRACE_PERIOD_L2_SLOTS` from 1200 to 8400
- Reduce `perBlockAllocationMultiplier` from 2 to 1.2

## Test plan
- Verify generated config files are updated after running `yarn
generate` in relevant packages
- Deploy to devnet/testnet and confirm slasher behavior matches new
parameters

---------

Co-authored-by: Aztec Bot <49558828+AztecBot@users.noreply.github.com>
This PR was created because merging `v4` into `v4-next` resulted in
conflicts.

Please resolve the conflicts and merge this PR to keep `v4-next` up to
date.

This PR was auto-generated by the `pull-v4-into-v4-next` workflow.
…20766)

Cherry-pick of merge commit 98363a7 from next. Contains conflict markers in
docs/docs-developers/docs/resources/migration_notes.md for reviewer visibility.
Kept v4-next's existing migration notes and added the SingleKeyAccountContract
removal note at the top of the TBD section. Removed duplicate 'aztec new' section
that came from the incoming cherry-pick.
…cription

The auto-generated CLI reference doc still had the old 'single-key account'
description. Updated to match the source code change.
@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Mar 13, 2026
@nchamo nchamo marked this pull request as ready for review March 13, 2026 18:30
@nchamo nchamo enabled auto-merge (squash) March 13, 2026 18:30
@nchamo nchamo self-assigned this Mar 13, 2026
@nchamo nchamo merged commit b22b45b into backport-to-v4-next-staging Mar 13, 2026
15 of 16 checks passed
@nchamo nchamo deleted the claudebox/backport-remove-schnorr-account-v4 branch March 13, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants