feat: filtering public logs by tag#21471
Closed
benesjan wants to merge 1 commit intomerge-train/fairiesfrom
Closed
feat: filtering public logs by tag#21471benesjan wants to merge 1 commit intomerge-train/fairiesfrom
benesjan wants to merge 1 commit intomerge-train/fairiesfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
changed the title
Contributor
|
Superceded by #21561. |
nventuro
added a commit
that referenced
this pull request
Mar 13, 2026
Reimplementation of #21471. I did the filtering in-memory as explained there due to lack of indices. Additionally I fixed a bug in which certain index tuples were ignored - e.g. if `afterLog` and `txHash` were both specified, `txHash` was ignored. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AztecBot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Reimplementation of #21471. I did the filtering in-memory as explained there due to lack of indices. Additionally I fixed a bug in which certain index tuples were ignored - e.g. if `afterLog` and `txHash` were both specified, `txHash` was ignored. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if the code in this PR is good because it doesn't leverage the tag index as was requested by this issue.
When I answered that F-224 seems to be implemented I was not aware that that index is not easily usable. The issue is that we seem to have multiple log types and the getPublicLogs function looks too complicated (see here).
This is the plan AI came up with:
This is what I propose: