feat!: improve L2ToL1MessageWitness API (backport #21231 to v4)#21462
Closed
AztecBot wants to merge 2 commits intobackport-to-v4-stagingfrom
Closed
feat!: improve L2ToL1MessageWitness API (backport #21231 to v4)#21462AztecBot wants to merge 2 commits intobackport-to-v4-stagingfrom
AztecBot wants to merge 2 commits intobackport-to-v4-stagingfrom
Conversation
Cherry-pick of a8b2277 from next. Conflicts left as-is for review.
Resolved conflicts in migration_notes.md (added new entries after TBD section) and block_store.ts (added getEpochAtSlot import).
Contributor
|
In favor of #21463 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21231 to v4.
The cherry-pick had conflicts in 2 files:
docs/docs-developers/docs/resources/migration_notes.md— new migration notes entries added after the## TBDsection (empty on v4, had other entries on next)yarn-project/archiver/src/store/block_store.ts— addedgetEpochAtSlotto the import from@aztec/stdlib/epoch-helpersBoth conflicts were straightforward content additions with no semantic changes needed.
Changes from the original PR
computeL2ToL1MembershipWitnesssignature changed: users no longer need to pass epoch number, instead query with(message, txHash)TxReceiptnow includesepochNumberfieldgetCheckpointsDataForEpochAPI exposed on the nodemessageIndexInTxparameter for disambiguating duplicate messagesCommit structure
No build fix commit was needed — the cherry-picked code compiles cleanly against v4.
ClaudeBox log: https://claudebox.work/s/3f04369c5e81d1ee?run=1