fix(archiver): backport filter tagged log queries by block number to v4#21430
Closed
AztecBot wants to merge 2 commits intobackport-to-v4-stagingfrom
Closed
fix(archiver): backport filter tagged log queries by block number to v4#21430AztecBot wants to merge 2 commits intobackport-to-v4-stagingfrom
AztecBot wants to merge 2 commits intobackport-to-v4-stagingfrom
Conversation
Collaborator
|
Closing as duplicate — superseded by a newer attempt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #21388 to v4.
Resolves the referenceBlock hash to a block number in the AztecNode and passes it down as
upToBlockNumberso the LogStore stops returning logs from blocks beyond the client's sync point. Also adds an ordering check on log insertion to guard against out-of-order appends.Cherry-pick details
errors.tsBlockAlreadyCheckpointedError(not present on v4), kept onlyOutOfOrderLogInsertionErrorNo additional build fixes were needed — all types and methods exist on v4.
ClaudeBox log: https://claudebox.work/s/b4ef30f9721afb3e?run=1