feat: add ETHEREUM_HTTP_TIMEOUT_MS env var for viem HTTP transport (backport to v4-next)#21429
Closed
AztecBot wants to merge 2 commits intobackport-to-v4-next-stagingfrom
Closed
Conversation
ludamad
force-pushed
the
backport-to-v4-next-staging
branch
from
5c50c04 to
4eb8703
Compare
Resolved conflict by keeping v4-next code structure (no parentBeaconBlockRoot conditional) while applying makeL1HttpTransport transport change.
ludamad
force-pushed
the
claudebox/backport-ethereum-http-timeout-v4-next
branch
from
4fa2524 to
7077ca3
Compare
Collaborator
|
Closing as duplicate — superseded by a newer attempt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #20919 to v4-next.
ETHEREUM_HTTP_TIMEOUT_MSenv var to configure the HTTP timeout on viem'shttp()transportmakeL1HttpTransporthelper inethereum/src/client.tsto centralize the repeatedfallback(urls.map(url => http(url, { batch: false })))patterncreatePublicClientcall sites to use the helper with the configurable timeoutCherry-pick details
fde4119e9f22c3d321bc7c85c08b87d4a25cf7effrom PR feat: add ETHEREUM_HTTP_TIMEOUT_MS env var for viem HTTP transport #20919yarn-project/blob-client/src/client/http.tsresolved: v4-next has a simpler code structure (noparentBeaconBlockRootconditional from a later refactor), so kept v4-next's structure while applying themakeL1HttpTransporttransport changeClaudeBox log: https://claudebox.work/s/d36a71c3e24da985?run=1